Detect absolute URL’s in the extra_* path.

[ericholscher]

refs #91

[tomchristie]

Is this intended to simply be {% else %}? What's the 'media' in path check for?

[ericholscher]

Yea, sorry. That was cruft left over from testing locally.

[jimporter]

It'd be nice if this wasn't done in the HTML templates; doing it this way means every theme needs to handle this if we want them to have feature-parity.

[ericholscher]

Agreed. I stuck it there because we are doing the base_url logic there as
well. I agree we could pre-process the URL's in the list and just include
them in the template as a single variable.

On Fri, May 30, 2014 at 11:23 AM, Jim Porter notifications@github.com
wrote:

In mkdocs/themes/readthedocs/base.html:

@@ -11,13 +11,20 @@

{% for path in extra_css %} - - {% if '//' in path %} - - {% elif 'media' in path %}

It'd be nice if this wasn't done in the HTML templates; doing it this way
means every theme needs to handle this if we want them to have
feature-parity.

—
Reply to this email directly or view it on GitHub
https://github.com/tomchristie/mkdocs/pull/92/files#r13242790.

Eric Holscher
Maker of the internet residing in Portland, Or
http://ericholscher.com

[ericholscher]

Went ahead and added this as a util function. Not sure if it fits in with the code-base or style perfectly. It seems like we should probably be using the urlparse module for this, but every time I've worked with it I want to stab something :)

I'm not sure if we want to support protocol-less things (eg. "media.cdn.org/foo.js") -- this code is naive and will include that as a local URL.

[hdngr]

would love to see Mkdocs support for Readthedocs...

[ericholscher]

I believe this should be merge-able now, if anyone would care to take a look.

[d0ugal]

Can you import urlparse from mkdocs.compat?

[tomchristie]

Yup, we should always keep version-branching code in compat.

[d0ugal]

I'm not even sure it's worth waiting for that tiny nitpick, but it would be good to remain consitent.

I'll wait and see if you happen to have time to update, otherwise I think this is good to merge.

[ericholscher]

Updated

[d0ugal]

Thanks! Looks like a linting error is breaking the Travis run tho' :(

[ericholscher]

Last try? :)

[edbrannin]

Shouldn't this be updating mkdocs/themes/mkdocs/base.html as well?

According to grep, mkdocs and readthedocs are the only themes that support extra_*:

(env)Ed-Brannins-MacBook-Pro:mkdocs-prs ed$ ack extra_  mkdocs/themes/
mkdocs/themes/mkdocs/base.html
19:        {% for path in extra_css %}<link href="{{ base_url }}/{{ path }}" rel="stylesheet">{% endfor %}
63:        {% for path in extra_javascript %}<script src="{{ base_url }}/{{ path }}"></script>{% endfor %}

mkdocs/themes/readthedocs/base.html
13:  {% for path in extra_css %}
19:  {% for path in extra_javascript %}

[ericholscher]

Thanks @edbrannin -- updated the default theme too :)

[tomchristie]

Rad.