Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow specifying heading_level as a Markdown heading instead #170

Merged
merged 5 commits into from Nov 4, 2020

Conversation

@oprypin
Copy link
Member

@oprypin oprypin commented Nov 1, 2020

This also refactors the regex to use the MULTILINE flag instead of the complex "manual" alternative for detecting newlines.

@oprypin oprypin force-pushed the oprypin:heading branch from 704e3eb to 0c6ba87 Nov 1, 2020
This also refactors the regex to use the MULTILINE flag instead of the complex "manual" alternative for detecting newlines.
@oprypin oprypin force-pushed the oprypin:heading branch from 0c6ba87 to feb3f88 Nov 1, 2020
oprypin added 2 commits Nov 3, 2020
@pawamoy
Copy link
Member

@pawamoy pawamoy commented Nov 3, 2020

Hehehe, you're quick 😉

Sorry for not merging in order 😅

@oprypin
Copy link
Member Author

@oprypin oprypin commented Nov 3, 2020

There would've been a conflict regardless. I was ready :)

@oprypin
Copy link
Member Author

@oprypin oprypin commented Nov 3, 2020

Hold on, I might have detected a buggy interaction with the passed config dict (now ChainMap but doesn't change the situation) here. This is mutating it, which may affect other things.

oprypin added 2 commits Nov 3, 2020
This actually happened to not cause any problems even with the mutation, but better to be safe.
@oprypin
Copy link
Member Author

@oprypin oprypin commented Nov 3, 2020

It is done.

This actually happened to not cause any problems even with the mutation, but better to be safe.

@pawamoy
Copy link
Member

@pawamoy pawamoy commented Nov 4, 2020

Great, thanks, squashing and merging!

@pawamoy pawamoy merged commit 10efc28 into mkdocstrings:master Nov 4, 2020
6 of 10 checks passed
6 of 10 checks passed
quality
Details
tests (ubuntu-latest, 3.6)
Details
tests (ubuntu-latest, 3.7)
Details
tests (ubuntu-latest, 3.8)
Details
tests (macos-latest, 3.6)
Details
tests (macos-latest, 3.7) tests (macos-latest, 3.7)
Details
tests (macos-latest, 3.8)
Details
tests (windows-latest, 3.6) tests (windows-latest, 3.6)
Details
tests (windows-latest, 3.7) tests (windows-latest, 3.7)
Details
tests (windows-latest, 3.8) tests (windows-latest, 3.8)
Details
@pawamoy pawamoy added this to 0.14.0 in Roadmap Nov 19, 2020
@pawamoy pawamoy mentioned this pull request Nov 19, 2020
0 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants