Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't wrongly discard text immediately before an autodoc #207

Merged
merged 1 commit into from Dec 30, 2020

Conversation

@oprypin
Copy link
Member

@oprypin oprypin commented Dec 30, 2020

foo
**foo**
::: some.identifier

In the previous state, the "foo" text would be completely obliterated, but now it will be kept, and the autodoc will be rendered as well.

```markdown
foo
**foo**
::: some.identifier
```

In the previous state, the "foo" text would be completely obliterated, but now it will be kept, and the autodoc will be rendered as well.
@oprypin
Copy link
Member Author

@oprypin oprypin commented Dec 30, 2020

@pawamoy
Copy link
Member

@pawamoy pawamoy commented Dec 30, 2020

This is great!

I guess it's an in-house workaround for Markdown versions lower than the next one containing your fix.

@oprypin
Copy link
Member Author

@oprypin oprypin commented Dec 30, 2020

No no, this is just another issue, one that is exactly parallel to the linked one, just that we happened to notice the linked one first

@pawamoy
Copy link
Member

@pawamoy pawamoy commented Dec 30, 2020

Oh OK, thank you for the explanation 🙂
EDIT: yes now that I re-read it carefully it's obvious 👍

@pawamoy pawamoy merged commit 07466fa into mkdocstrings:master Dec 30, 2020
0 of 13 checks passed
0 of 13 checks passed
quality quality
Details
tests (ubuntu-latest, 3.6) tests (ubuntu-latest, 3.6)
Details
tests (ubuntu-latest, 3.7) tests (ubuntu-latest, 3.7)
Details
tests (ubuntu-latest, 3.8) tests (ubuntu-latest, 3.8)
Details
tests (ubuntu-latest, 3.9) tests (ubuntu-latest, 3.9)
Details
tests (macos-latest, 3.6) tests (macos-latest, 3.6)
Details
tests (macos-latest, 3.7) tests (macos-latest, 3.7)
Details
tests (macos-latest, 3.8) tests (macos-latest, 3.8)
Details
tests (macos-latest, 3.9) tests (macos-latest, 3.9)
Details
tests (windows-latest, 3.6) tests (windows-latest, 3.6)
Details
tests (windows-latest, 3.7) tests (windows-latest, 3.7)
Details
tests (windows-latest, 3.8) tests (windows-latest, 3.8)
Details
tests (windows-latest, 3.9) tests (windows-latest, 3.9)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants