Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't mutate the original Markdown config for permalinks #212

Merged
merged 1 commit into from Jan 3, 2021

Conversation

@oprypin
Copy link
Member

@oprypin oprypin commented Jan 3, 2021

This was a regression from #203.
This ended up disabling permalinks outright for all docs.

This was a regression from #203.
This ended up disabling permalinks outright for all docs.
@pawamoy
Copy link
Member

@pawamoy pawamoy commented Jan 3, 2021

Regressions run against 0.13.6 with this change

Hmmm, code tag in a code tag? How does it compare with 0.14.0b1?

@oprypin
Copy link
Member Author

@oprypin oprypin commented Jan 3, 2021

(cd ~/repos/mkdocstrings && git bisect start HEAD 0.13.6 && git bisect run bash -c 'cd ~/repos/mkdocstrings-regressions/repos/copier-org-copier && PYTHONPATH=~/repos/mkdocstrings/src venv/bin/mkdocs build || exit 125; ! grep "data: <code class=\"highlight language-python\">" site/reference/config/objects/index.html')

1028115 is the first bad commit

@pawamoy
Copy link
Member

@pawamoy pawamoy commented Jan 3, 2021

Yeah just found it, you beat me to it 😄

@pawamoy
Copy link
Member

@pawamoy pawamoy commented Jan 3, 2021

So, since the double tags come from another commit, this PR is OK to be merged!

@pawamoy pawamoy merged commit fd71a11 into mkdocstrings:master Jan 3, 2021
13 checks passed
13 checks passed
quality
Details
tests (ubuntu-latest, 3.6)
Details
tests (ubuntu-latest, 3.7)
Details
tests (ubuntu-latest, 3.8)
Details
tests (ubuntu-latest, 3.9)
Details
tests (macos-latest, 3.6)
Details
tests (macos-latest, 3.7)
Details
tests (macos-latest, 3.8)
Details
tests (macos-latest, 3.9)
Details
tests (windows-latest, 3.6)
Details
tests (windows-latest, 3.7)
Details
tests (windows-latest, 3.8)
Details
tests (windows-latest, 3.9)
Details
@pawamoy pawamoy mentioned this pull request Jan 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants