Support new mkdocstrings_handlers namespace #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawamoy
force-pushed
the
find-handlers-in-mkdocstrings_handlers
branch
from
0aad9b2
to
b8e73d7
Compare
|
Lets not emit deprecation warnings for our own legacy handler. Users don't care about them. |
|
@oprypin do you want us not to emit these deprecation warnings for the crystal handler as well? |
|
@pawamoy Well yes but that will just be done by making the handler use the new approach |
|
Indeed, it's just in case you don't plan to upgrade your handler immediately and don't want to bother your users with a deprecation warning they have no control over. Let me know. |
oprypin
reviewed
Feb 4, 2022
| @@ -42,7 +40,7 @@ See the documentation for | |||
| [`BaseRenderer`][mkdocstrings.handlers.base.BaseRenderer]. | |||
|
|
|||
| Check out how the | |||
| [Python handler](https://github.com/pawamoy/mkdocstrings/blob/master/src/mkdocstrings/handlers/python.py) | |||
| [Python handler](https://github.com/mkdocstrings/python/blob/master/src/mkdocstrings_handlers/python) | |||
There was a problem hiding this comment.
#356 will remove this destination though
There was a problem hiding this comment.
Hmmm no I think it's right: this link points to the extracted Python handler, i.e. its own repository in the org, and not mkdocstrings' repo.
pawamoy
force-pushed
the
find-handlers-in-mkdocstrings_handlers
branch
from
f9cd116
to
2b6561c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.