Add object only api #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allow user to only pass in an object, with a key of url. maintains backwards compatibility.
|
Hows that? |
|
Looks good. Could you update the readme to reflect this change? @mkdynamic what do you think about this? |
|
Ill do that today. |
|
Any chance this could land? |
|
Looks good to me fwiw. @lencioni |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow user to only pass in an object, with a key for url. This commit maintains backwards
compatibility.
This is optional, I like passing 1 (potentially complex) object to a function. This is cleaner
in my opinion, and for only a couple of lines I think its should be added in the base project.
I use this by defining a set of defaults I always want to use, then when I'm ready to call the
plugin I extend my setting array with the specifics of that call.
Again, this is purely preference, but I prefer this api, and others may also.