Prevent oauth2 from interpreting Facebook's expires field as expires_in, when it's really expires_at #39

Merged
merged 4 commits into from Apr 30, 2012

Projects

None yet

2 participants

@watsonbox
Contributor

No description provided.

Owner

Thanks, good catch on the OAuth2 field. If you can add a spec for that, I will merge.

Could you describe the scenario where you're using the always_refresh_access_token option?

Owner

This seems related to #40.

Also, perhaps it may be worth considering the option of exchanging the short-lived token vs. obtaining a new one:
https://developers.facebook.com/roadmap/offline-access-removal/#extend_token

The outcome may be the same, but the exchange mechanism seems to be what FB suggest.

Contributor

You're quite right the initialization option pertains to #40. Will add further comments there. Added spec as requested.

Owner

Thanks!

@mkdynamic mkdynamic merged commit 0c18c7c into mkdynamic:master Apr 30, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment