jsdom has no method env #65

Closed
jeremiefourbil opened this Issue Sep 4, 2012 · 2 comments

Comments

Projects
None yet
2 participants

In the task dom.js it seems that the function processFile is called without his second argument jsdom in line 88.

processFile(f , function(err, window) { ... }

the result is

.../node_modules/node-build-script/tasks/dom.js:148
    jsdom.env({
          ^
TypeError: Object function (err, window) {
      if(err) return cb(err);
...
function next() {
        if(--ln) return;
        cb(null, window.document.innerHTML, window);
      }
    } has no method 'env'

jeremiefourbil reopened this Sep 4, 2012

Owner

mklabs commented Sep 12, 2012

Thanks @jeremiefourbil for the feedback. You're absolutely true.

To be honest, the dom task might be killed off due to Windows support. usemin blocks (using HTML comments) and regexp parsing will kinda act as our basic parser.

Owner

mklabs commented Jan 14, 2013

Closing. The jsdom based build will be removed from next version.

mklabs closed this Jan 14, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment