update data-main to point to the minfied main.js #53

Merged
merged 2 commits into from Aug 1, 2012

Conversation

Projects
None yet
3 participants
Contributor

martinblech commented Jul 31, 2012

On RequireJS projects, the build script must update both src and data-main attributes of the script tag to point to the minified versions. Now it does.

Contributor

martinblech commented Aug 1, 2012

If the rjs.almond option in grunt.js is set to true, the build script removes references to requirejs from html and includes almond instead.

Owner

mklabs commented Aug 1, 2012

Sounds like really good changes. Thanks! Merged.

The only missing things would be some unit tests to test out this new feature, but tests are kinda difficult to grasp right now and not really well documented.

mklabs added a commit that referenced this pull request Aug 1, 2012

Merge pull request #53 from martinblech/master
update data-main to point to the minfied main.js

@mklabs mklabs merged commit d1b3f8f into mklabs:master Aug 1, 2012

Contributor

martinblech commented Aug 1, 2012

I've implemented unit tests for this new feature here: h5bp#54

Contributor

martinblech commented Aug 1, 2012

@paulirish / @mklabs is this or something similar gonna be in Yeoman? Can I have a look?

Owner

mklabs commented Aug 29, 2012

@martinblech Something similar will be in Yeoman yes. Feel free to ping @addyosmani to be include in the beta tester group, if it's ok to Addy. It's not up to me :)

Hey,

Im having this exact issue with h5bp that i got today (17-Oct-2012). Is this issue open again now h5bp is using Yeoman?

Owner

mklabs commented Oct 17, 2012

Hey @andrewkro nothing is decided yet. This project is not using yeoman (only in ymn branch for now to experiment). If you're using node-build-script pointing to master branch, you should have @martinblech fixes around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment