GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
On RequireJS projects, the build script must update both src and data-main attributes of the script tag to point to the minified versions. Now it does.
update data-main attribute to link to the minified main.js
added an option to replace requirejs with almond during build
If the rjs.almond option in grunt.js is set to true, the build script removes references to requirejs from html and includes almond instead.
Sounds like really good changes. Thanks! Merged.
The only missing things would be some unit tests to test out this new feature, but tests are kinda difficult to grasp right now and not really well documented.
Merge pull request #53 from martinblech/master
update data-main to point to the minfied main.js
I've implemented unit tests for this new feature here: h5bp#54
@paulirish / @mklabs is this or something similar gonna be in Yeoman? Can I have a look?
@martinblech Something similar will be in Yeoman yes. Feel free to ping @addyosmani to be include in the beta tester group, if it's ok to Addy. It's not up to me :)
Im having this exact issue with h5bp that i got today (17-Oct-2012). Is this issue open again now h5bp is using Yeoman?
Hey @andrewkro nothing is decided yet. This project is not using yeoman (only in ymn branch for now to experiment). If you're using node-build-script pointing to master branch, you should have @martinblech fixes around.