Skip to content

Mickael Daniel
mklabs

Organizations

@lyonjs @h5bp
May 4, 2016
mklabs commented on pull request yeoman/yo#426
@mklabs

I agree. Still, I'd prefer to have this test case covered. If you don't mind, Il'l probably add an npm install / npm uninstall as setup / teardown …

May 4, 2016
mklabs commented on pull request yeoman/yo#426
@mklabs

@SBoudrias Thank you for the review. I'll probably won't have much time today to work on it, but should be ok by tomorrow.

May 4, 2016
mklabs commented on pull request yeoman/yo#426
@mklabs

oops :confused:

May 2, 2016
mklabs pushed to completion at mklabs/yo
@mklabs
  • @mklabs a087cc9
    completion: Add completion based on env.getGeneratorsMeta() and --help
May 2, 2016
mklabs pushed to completion at mklabs/yo
@mklabs
  • @mklabs ca899df
    completion: skip test on user installed generators
May 2, 2016
mklabs commented on pull request yeoman/yo#426
@mklabs

Fighting against Travis right now, will squash all these commits once done.

May 2, 2016
mklabs commented on pull request yeoman/yo#426
@mklabs

@addyosmani Thanks!

May 2, 2016
mklabs pushed to completion at mklabs/yo
@mklabs
May 2, 2016
mklabs commented on pull request yeoman/yo#426
@mklabs

@SBoudrias @sindresorhus currently pushing updated code with a few tests. Should be up for review. Reworked the completion system in its own folder…

May 2, 2016
mklabs pushed to completion at mklabs/yo
@mklabs
  • @mklabs 3e048a4
    completion: comply with Travis yelling at me
May 2, 2016
mklabs pushed to completion at mklabs/yo
@mklabs
  • @mklabs 48bb56b
    completion: comply with eslint yelling at me
May 2, 2016
mklabs pushed to completion at mklabs/yo
@mklabs
May 2, 2016
@mklabs
meow-plus
May 2, 2016
mklabs commented on pull request yeoman/yo#426
@mklabs

I never use it, thanks. The child_process.execFile() function is similar to child_process.exec() except that it does not spawn a shell. Rather, th…

May 2, 2016
mklabs commented on pull request yeoman/yo#426
@mklabs

:tada: Happy that you guys like it. I'll push reviews edit and think about how to test it. Are you ok with the state of this PR ? We have a lot of opti…

May 2, 2016
mklabs pushed to completion at mklabs/yo
@mklabs
May 2, 2016
mklabs pushed to completion at mklabs/yo
@mklabs
  • @mklabs 4978ae6
    Prevent completion install on CI environments
May 2, 2016
mklabs opened pull request yeoman/yo#426
@mklabs
Add completion based on env.getGeneratorsMeta() and --help
1 commit with 97 additions and 3 deletions
May 2, 2016
@mklabs
  • @mklabs bb4216c
    feat: implement a basic cache mechanism
mklabs created branch completion at mklabs/yo
May 2, 2016
May 1, 2016
mklabs commented on pull request yeoman/environment#60
@mklabs

no worries :) Thanks to you Simon for this lib and getGeneratorsMeta(), very reliable way of getting user installed generators. I might be able to …

May 1, 2016
mklabs commented on pull request yeoman/environment#60
@mklabs

yep

May 1, 2016
@mklabs
  • @mklabs 6cff82e
    review: dirname not reused, inline it
May 1, 2016
mklabs commented on pull request yeoman/environment#60
@mklabs

👌

May 1, 2016
mklabs commented on pull request yeoman/environment#60
@mklabs

ok

May 1, 2016
@mklabs
  • @mklabs a156a73
    review: test against raw value
May 1, 2016
mklabs commented on pull request yeoman/environment#60
@mklabs

Alright, f253be0 should fix it

May 1, 2016
@mklabs
  • @mklabs f253be0
    review: dont abstract away tests
May 1, 2016
@mklabs
  • @mklabs 1f913a3
    review: delete process.env[env]
May 1, 2016
mklabs commented on pull request yeoman/environment#60
@mklabs

oops, forgot to put it back. Was a test when struggling with this test particularly.

Something went wrong with that request. Please try again.