lcrypto: make it build under windows #12

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@philips
Contributor

philips commented Feb 8, 2012

Move all of the variable definitions to the top. Builds under MS Visual Studio 2010 now.

Brandon Philips
lcrypto: make it build under windows
Move all of the variable definitions to the top.
@mkottman

This comment has been minimized.

Show comment Hide comment
@mkottman

mkottman Feb 8, 2012

Owner

Is this the last pull request? I would rather merge one pull request (with a lot of commits) than merge each commit individually :)

Owner

mkottman commented Feb 8, 2012

Is this the last pull request? I would rather merge one pull request (with a lot of commits) than merge each commit individually :)

@philips

This comment has been minimized.

Show comment Hide comment
@philips

philips Feb 8, 2012

Contributor

Last pull request for what? With this pull request it does build under windows.d

Contributor

philips commented Feb 8, 2012

Last pull request for what? With this pull request it does build under windows.d

@philips

This comment has been minimized.

Show comment Hide comment
@philips

philips Feb 8, 2012

Contributor

FWIW, I thought the last pull request was enough because the MS compiler uses C89 which doesn't allow inline. But it also doesn't allow variable definitions in the body of the function...

Contributor

philips commented Feb 8, 2012

FWIW, I thought the last pull request was enough because the MS compiler uses C89 which doesn't allow inline. But it also doesn't allow variable definitions in the body of the function...

@mkottman

This comment has been minimized.

Show comment Hide comment
@mkottman

mkottman Feb 8, 2012

Owner

I was asking more generally with the pull requests - do you have any other new functionality in mind? I do not have currently time/resources to thoroughly test luacrypto, therefore I would like to accept pull requests less frequently - once a month would be ideal, so that I can test if all changes work as expected.

I.e. please send a pull request after a set of tested commits.

Owner

mkottman commented Feb 8, 2012

I was asking more generally with the pull requests - do you have any other new functionality in mind? I do not have currently time/resources to thoroughly test luacrypto, therefore I would like to accept pull requests less frequently - once a month would be ideal, so that I can test if all changes work as expected.

I.e. please send a pull request after a set of tested commits.

@mkottman

This comment has been minimized.

Show comment Hide comment
@mkottman

mkottman Mar 1, 2012

Owner

Merged in commit eeee4bc

Owner

mkottman commented Mar 1, 2012

Merged in commit eeee4bc

@mkottman mkottman closed this Mar 1, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment