71 collection #76
71 collection #76
Conversation
Codecov Report
@@ Coverage Diff @@
## master #76 +/- ##
=======================================
Coverage 33.33% 33.33%
=======================================
Files 1 1
Lines 18 18
Branches 6 5 -1
=======================================
Hits 6 6
Misses 12 12
Continue to review full report at Codecov.
|
src/scenes/Player.ts
Outdated
| @@ -6,7 +6,8 @@ export class Player implements IPlayer { | |||
| constructor( | |||
| private graph: Graph, | |||
| private location: ILocation, | |||
| public stock = 3, | |||
| // tslint:disable-next-line:variable-name | |||
There was a problem hiding this comment.
what's the reason for having to disabling the linter?
src/scenes/mainScene.ts
Outdated
| @@ -86,6 +89,54 @@ export class MainScene extends Scene { | |||
| this.playerTurnInfo.setText(this.player.turn.toString()); | |||
| this.updateBuildFactoryButton(); | |||
| this.updateCityInfos(); | |||
| this.updateVisibility(); | |||
There was a problem hiding this comment.
who's visibility is updated? The + - buttons?
There was a problem hiding this comment.
Name has been changed. New pull request will follow immediately. I was planning to extend the method to handle more GameObjects but it does not seem necessary at the moment.
src/scenes/mainScene.ts
Outdated
| @@ -314,6 +375,9 @@ export class MainScene extends Scene { | |||
| } | |||
|
|
|||
| private drawEdges(cities: ICity[]) { | |||
| this.travelPathLines = this.add.graphics({ | |||
There was a problem hiding this comment.
this line occurs 3 times, consider extract method
There was a problem hiding this comment.
It's done. New pull request will follow immediately.
No description provided.