Marijn Kruisselbrink mkruisselbrink

  • Google
  • Joined on
@mkruisselbrink
@mkruisselbrink
@mkruisselbrink
@mkruisselbrink
Nit: Let geofence be a new geofence.
@mkruisselbrink
Move uniqueness of id
@mkruisselbrink
Redudant assertion
@mkruisselbrink

That makes sense. Somehow I always make the mistakes of copying from the wrong examples :)

@mkruisselbrink

I agree that having this duplicated is not good. I'm not entirely sure what an appropriate place to define this would be though. I've now moved it …

@mkruisselbrink

I'm not entirely sure about that, although you're right that that algorithm does need to actually create an actual Geofence instance to resolve the…

@mkruisselbrink

So it's not enough that webidl defines a sequence and that it binds to an array in JS? I'll change it to array...

@mkruisselbrink

I think it's better to keep the examples conforming to ES6 until there is actual consensus on ES7 and ES7 is actually a standard.

@mkruisselbrink
@mkruisselbrink

So does something like the API described in docs/api-idea.md seem like the right way to go then?

@mkruisselbrink
@mkruisselbrink
@mkruisselbrink
Typo
1 commit with 1 addition and 1 deletion
@mkruisselbrink
@mkruisselbrink
Typo: resolve promise with a false
@mkruisselbrink
World Geodetic System
@mkruisselbrink

I'm not sure about this. I kind of agree that the text doesn't add much, but it also seems weird to have a field without any description. At least …

@mkruisselbrink

I think a big benefit of something like the stashed ports idea is that it can be used for any MessagePort. It doesn't somehow special treat Message…

@mkruisselbrink

@jakearchibald is your proposal that https://font-service/sw.js would only be allowed to intercept requests from service workers (and their control…

@mkruisselbrink

I don't really like the idea of having in this case the foo service worker specify the exact path to the font-service service worker script. It see…

@mkruisselbrink

I think the idea was that this would use the same network-headers to figure out what scope and script URL to use. So in your example, the user agen…

@mkruisselbrink

Yes, completely agree with this. Both n.c and request interception are ways to enable cross-origin service worker communication, but they are diffe…

@mkruisselbrink
mkruisselbrink merged pull request w3c/geofencing-api#2
@mkruisselbrink
fixing typos
1 commit with 2 additions and 2 deletions
@mkruisselbrink
@mkruisselbrink
  • @mkruisselbrink 91bcefb
    Update examples to better illustrate expected API usage.
@mkruisselbrink
The default branch for this repo should be 'gh-pages' not 'master'