New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XXE in ImportFromSMathStudio.java #79

Closed
ProDigySML opened this Issue Sep 29, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@ProDigySML
Copy link

ProDigySML commented Sep 29, 2018

The Issue

An XML External Entity attack is a type of attack against an application that parses XML input. This attack occurs when XML input containing a reference to an external entity is processed by a weakly configured XML parser. This attack may lead to the disclosure of confidential data, denial of service, server side request forgery, port scanning from the perspective of the machine where the parser is located, and other system impacts.

Where the Issue Occurred

The following code snippets display the usage of DocumentBuilderFactory without securely disabling entities:

@mkulesh

This comment has been minimized.

Copy link
Owner

mkulesh commented Oct 10, 2018

Dear @ProDigySML, thanks for submitting this issue. I studied https://www.owasp.org/index.php/XML_External_Entity_(XXE)_Prevention_Cheat_Sheet and found, that only setExpandEntityReferences(false) is possible for Android DocumentBuilderFactory. All other recommendations from above mentioned link produce some exceptions. Therefore, I only added setExpandEntityReferences(false) for the DocumentBuilderFactory. I hope, the problem is solved. Are you agree with this solution?

@mkulesh mkulesh self-assigned this Oct 10, 2018

@mkulesh mkulesh added the bug label Oct 10, 2018

@mkulesh mkulesh added this to the Implemented milestone Oct 10, 2018

@mkulesh

This comment has been minimized.

Copy link
Owner

mkulesh commented Nov 4, 2018

Fixed and released in 2.17.3

@mkulesh mkulesh closed this Nov 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment