Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the version number of the library. #283

Merged
merged 3 commits into from Feb 18, 2019

Conversation

Projects
None yet
3 participants
@champierre
Copy link
Contributor

champierre commented Feb 16, 2019

This is PR that is related to #280

champierre added some commits Feb 16, 2019

@shiffman

This comment has been minimized.

Copy link
Member

shiffman commented Feb 18, 2019

This looks great to me, but I will leave to @joeyklee to merge! ❤️

@joeyklee joeyklee merged commit 6aa3d1d into ml5js:master Feb 18, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@joeyklee

This comment has been minimized.

Copy link
Contributor

joeyklee commented Feb 18, 2019

Hi @champierre! Excellent. Nice, simple & elegant solution. Thanks for this addition!

@champierre

This comment has been minimized.

Copy link
Contributor Author

champierre commented Feb 18, 2019

@joeyklee Thank you for merging. Actually, I am not good at Node.js, so looked at other projects and found that way.

@joeyklee

This comment has been minimized.

Copy link
Contributor

joeyklee commented Feb 18, 2019

@champierre - Super. Thanks for sharing your contributions + findings!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.