Add ESLint GitHub Action for automated PR review comments #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bomanimc
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/index.js
Outdated
| @@ -34,7 +34,7 @@ import universalSentenceEncoder from './UniversalSentenceEncoder'; | |||
| import p5Utils from './utils/p5Utils'; | |||
| import communityStatement from './utils/community'; | |||
|
|
|||
| const withPreload = { | |||
| let withPreload = { | |||
There was a problem hiding this comment.
[eslint] reported by reviewdog 🐶
'withPreload' is never reassigned. Use 'const' instead. prefer-const
There was a problem hiding this comment.
Nice! It's working! I'll be removing this change from the PR.
bomanimc
force-pushed
the
bomani.eslint-reviews
branch
from
8c0954f
to
f691d32
Compare
|
Merging now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to include a new GitHub Action that will run ESLint on PRs to this repo and comment with lint errors. This will help us avoid adding new lint errors into the codebase as we start forwarding on the path of getting these fixed.
This approach uses the reviewdog ESLint action.
Here's an example of what the comments look like:
