Fix fetching of protocol paramters if they are not specified in confi… #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szg251
reviewed
Jul 21, 2022
src/BotPlutusInterface/Config.hs
Outdated
| Left err -> return $ Left $ "PABConfig: " <> fn <> ": " <> err | ||
| Right conf@PABConfig {pcProtocolParamsFile, pcNetwork, pcCliLocation} -> do | ||
| pparamsE <- readProtocolParametersJSON (toString pcProtocolParamsFile) | ||
| pparamsE <- readProtocolParametersJSON (toString pcProtocolParamsFile) `catch` (\(e :: IOException) -> pure $ Left (show e)) |
Collaborator
There was a problem hiding this comment.
Could we include the catch in readProtocolParametersJSON? It already returns an Either, so it would make sense, if IO errors would also be caught there.
Collaborator
There was a problem hiding this comment.
ngua
approved these changes
Jul 21, 2022
…g and if file is not present Previously we would only fetch the file if JSON.decode returned a Left, however if the file is not present an IOError will be thrown and the code to fetch the file through the CLI was never being executed Change-type: patch Signed-off-by: Giovanni Garufi <giovanni@mlabs.city>
nazrhom
force-pushed
the
nazrhom/fix-fetch-protocol-params
branch
from
552b7bf to
546e3bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…g and if file is not present
Previously we would only fetch the file if JSON.decode returned a Left, however if the file is not present an IOError
will be thrown and the code to fetch the file through the CLI was never being executed
Change-type: patch
Signed-off-by: Giovanni Garufi giovanni@mlabs.city