Time related functionalities #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
szg251
commented
Feb 1, 2022
szg251
commented
- Add awaitSlot, waitNSlots, currentTime, currentSlots contract effect handlers
- Add validity range functions
- Test on real chain with examples
added 14 commits
January 20, 2022 18:27
…plutus-interface into gergely/wait-slots
This was referenced Feb 3, 2022
test/Spec/MockContract.hs
Outdated
Comment on lines
321
to
323
| let slot = Text.pack $ show $ getSlot $ tipSlot (state ^. tip) | ||
| blockId = decodeUtf8 $ getBlockId $ tipBlockId (state ^. tip) | ||
| blockNo = Text.pack $ show $ unBlockNumber $ tipBlockNo (state ^. tip) |
Contributor
There was a problem hiding this comment.
Maybe unpack the tip before hand to avoid repition
Can use namepuns like
Suggested change
| let slot = Text.pack $ show $ getSlot $ tipSlot (state ^. tip) | |
| blockId = decodeUtf8 $ getBlockId $ tipBlockId (state ^. tip) | |
| blockNo = Text.pack $ show $ unBlockNumber $ tipBlockNo (state ^. tip) | |
| let Tip {tipSlot, tipBlockId, tipBlockNo} = state ^. tip | |
| slot = Text.pack $ show $ getSlot tipSlot | |
| blockId = decodeUtf8 $ getBlockId tipBlockId | |
| blockNo = Text.pack $ show $ unBlockNumber tipBlockNo |
Collaborator
Author
There was a problem hiding this comment.
The problem is the same here, Tip is a sum type, so I realised that the record functions are partial here. Used a good old case statement instead.
samuelWilliams99
approved these changes
Feb 4, 2022
| tell $ Last $ Just "Finished" | ||
| where | ||
| toTx :: [(PubKeyHash, Value)] -> TxConstraints Void Void | ||
| toTx = mconcat . map (uncurry Constraints.mustPayToPubKey . first PaymentPubKeyHash) |
Contributor
There was a problem hiding this comment.
Theres mconcatMap in Data.List.Extra, but unsure if its worth it. Happy to merge as is
Collaborator
Author
|
@samuelWilliams99 Sorry for adding these after you approved this, but I wanted to incorporate a few more changes in this PR.
|
samuelWilliams99
approved these changes
Feb 11, 2022
Contributor
|
No worries! Looks good to me :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.