-
Notifications
You must be signed in to change notification settings - Fork 10
Fix signing keys and txs folder on remote #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
szg251
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I assume you have already checked with a real remote server.
Might not really worth the effort, but I think we could extend the MockContract testing framework so that it checks for files on cli calls, so we don't run into the same kind of trouble after a refactoring.
|
Yep I've tested on real remote. I havent however tested on local, as I dont have that environment readily available. I don't expect these changes to even remotely affect Local, but it might be worth checking if you know of a quick way to do so? |
|
I'll just check them myself |
|
As for testing, how do you mean? Would we keep track of a mock file system and parse the cli calls to ensure they refer to existing files? |
|
We already have that mock file system here: https://github.com/mlabs-haskell/bot-plutus-interface/blob/master/test/Spec/MockContract.hs#L198 but it doesn't handle uploadDir yet |
|
@samuelWilliams99 Did a few tests with the examples on the local environment, it looks good. |
Depends, we dont need to parse the whole thing. theres a set of specific flags that are followed by a path, we can just look for those then grab the next thing up to a space (or quoted) |
|
I think the tests would probably go best with the |
|
Or, at the very least, a new ticket. This one is a bug fix |
|
Going to handle the mock file system improvements in #65 |
When operating with a remote CLI, I noticed a few issues:
txsfolder is always created on the local machine, whereas, if we're running remote, it needs to be on the remote machine