Migrating pre-commit-hooks from LB #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
added 2 commits
February 2, 2024 18:31
- Removed `./examples/pre-commit.nix` in favour of augmenting
`./pre-commit.nix`
- Justification: I'd prefer to keep all the `pre-commit` things in a
single file.
- Added a `flakeModule.rustMonorepoPreCommit` attribute which contains a
module for formatting rust code
- Justification: This copies the API given in
https://github.com/cachix/pre-commit-hooks.nix/blob/7c54e08a689b53c8a1e5d70169f2ec9e2a68ffaf/flake.nix#L27.
My reading of this is that we want to expose a flake module which
enables the rust formatter. @szg251 if we're happy with this, I
can try to get this patched in `pre-commit-hooks.nix` as a more
permanent fix.
- Removed deno precommit hooks
- Justification: originally we rolled our own `deno` precommit
things because the default was slightly broken. But it has now
been patched -- see cachix/git-hooks.nix#377
Contributor
|
@bladyjoker I picked up on this in #21 |
…-migration Migrating precommit hooks from LB
Contributor
Author
|
@jaredponn PTAL. We need to open issues for adding examples and versioning. |
jaredponn
force-pushed
the
bladyjoker/flake-lang-migration
branch
from
7a1c39a to
8ba7752
Compare
it lines up nicely with the already existing system with flake-parts https://flake.parts/options/flake-parts#opt-flake.flakeModules
Contributor
|
@bladyjoker looks good to me. I made one minor edit:
|
jaredponn
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DONE