-
Notifications
You must be signed in to change notification settings - Fork 2
Bootstrap the repo #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| | Enum | ||
| | Bounded | ||
| | HasConstrIndex | ||
| | ToData |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this? I.e. do we really expect anyone using the library to want to generate HasConstrIndices instances but not To/FromData instances?
Either way I think mkSumTypeIndexed should generate ToData/FromData instances by default. Maybe we should rename it to mkPlutusSum or something like that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I completely agree!
|
I think everything here is good. Going to merge it in a second. |
|
@gnumonik that's it from me today, I didn't manage to generate the instance clauses so if you can, I'd be happy if you could continue with the following:
We need to be able to continue user registration tomorrow, for that we need ToData/FromData instances. Cheers, |
…now. mkSumTypeIndexed + its extremelyUnsafe friend now generate Argonaut JSON instances by default. Test updated to account for those two changes. Test now passes.
|
Notes (mainly for my own benefit):
|
Hey @gnumonik, we have some goodies here I want you to check out: