Skip to content

Conversation

@rynoV
Copy link
Contributor

@rynoV rynoV commented Jul 29, 2022

Updates CI to not run the build while a PR is still a draft, then run the build normally when and after it becomes ready for review.

To test, I made this PR a draft and the build was skipped, and when I made it ready for review, the build was started

@rynoV rynoV marked this pull request as ready for review July 29, 2022 20:23
@t4ccer
Copy link
Contributor

t4ccer commented Jul 30, 2022

Why do we want it?

@t4ccer
Copy link
Contributor

t4ccer commented Jul 30, 2022

BTW, we need to move this repo to hydra

@rynoV
Copy link
Contributor Author

rynoV commented Jul 30, 2022

@t4ccer the current configuration discourages from pushing work frequently because the build runs on every push (which isn't entirely free, and is also unnecessary while the PR is in draft)

@samuelWilliams99
Copy link
Contributor

This is fine by me, we'll be moving to hydra anyway so not an issue

@rynoV rynoV merged commit 059df8b into master Aug 1, 2022
@rynoV rynoV deleted the calum/no-ci-for-drafts branch August 1, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants