Skip to content

Commit 05ec620

Browse files
committed
fix(menu): Added fixes required for Concurrent Rendering
1 parent 75663e4 commit 05ec620

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

packages/menu/src/Menu.tsx

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -210,12 +210,14 @@ export const Menu = forwardRef<HTMLDivElement, MenuProps>(function Menu(
210210

211211
const [cancelled, setCancelled] = useState(false);
212212
const prevVisible = useRef(visible);
213-
if (prevVisible.current !== visible) {
214-
prevVisible.current = visible;
215-
if (cancelled) {
216-
setCancelled(false);
213+
useEffect(() => {
214+
if (prevVisible.current !== visible) {
215+
prevVisible.current = visible;
216+
if (cancelled) {
217+
setCancelled(false);
218+
}
217219
}
218-
}
220+
}, [visible, cancelled]);
219221

220222
const fixedTo = useRef<HTMLElement | null>(null);
221223
useEffect(() => {

0 commit comments

Comments
 (0)