Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sass vs node-sass visual difference #1015

Closed
stickfigure opened this issue Nov 24, 2020 · 1 comment
Closed

sass vs node-sass visual difference #1015

stickfigure opened this issue Nov 24, 2020 · 1 comment
Labels
Milestone

Comments

@stickfigure
Copy link
Contributor

rmd 2.4.3, chrome 86.

Exact same code, the only difference is replacing node-sass with sass+fibers in the package.json.

The node-sass version of a menu, with spacing between text and icon:

https://monosnap.com/file/2CeDgaOLTNthsTUeof3M0INGeafvcq

The sass version seem to be missing the spacing:

https://monosnap.com/file/GkjQlIrur72aFHWYVfgEONFIKJCO3T

This seems to work in one place but not the other:

.rmd-icon--before {
    margin-right: var(--rmd-icon-text-spacing, 0.5rem);
}
@mlaursen
Copy link
Owner

Darn.. This probably means sass doesn't like this mixin if all the other text icon spacing works. Wonder if there's a difference in how strings/escaping between the two.

@mlaursen mlaursen added this to the v2.5.1 milestone Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants