New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark theme elevation feature overrides custom background colors #1075
Comments
Whoops, this was an unintended side-effect of using @mixin rmd-theme-dark-elevation-styles and @mixin rmd-theme-dark-elevation to implement the dark elevation styles. I'll introduce new SCSS variables to help solve this as well as reduce the specificity for the dark elevation styles. This bug current affects:
|
mlaursen
added a commit
that referenced
this issue
Feb 27, 2021
mlaursen
added a commit
that referenced
this issue
Feb 27, 2021
mlaursen
added a commit
that referenced
this issue
Feb 27, 2021
mlaursen
added a commit
that referenced
this issue
Feb 27, 2021
mlaursen
added a commit
that referenced
this issue
Feb 27, 2021
mlaursen
added a commit
that referenced
this issue
Feb 27, 2021
Merged
Thank you for the clarification! I'll disable the dark elevation for now. |
mlaursen
added a commit
that referenced
this issue
Feb 28, 2021
mlaursen
added a commit
that referenced
this issue
Feb 28, 2021
mlaursen
added a commit
that referenced
this issue
Feb 28, 2021
mlaursen
added a commit
that referenced
this issue
Feb 28, 2021
mlaursen
added a commit
that referenced
this issue
Feb 28, 2021
mlaursen
added a commit
that referenced
this issue
Feb 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The SASS variable of some components are being overridden when using dark Theme.

Look, the image shows a style ".dark-theme .rmd-toast" where the variable "--rmd-theme-background" are being set again for some reason.
Below at the class ".dark-theme" i globally defined that variable.
The code that i use for theme switch:
What is the expected behavior?
The variable should not be overridden in the dark theme.
A little about versions:
Windows
Chrome
"react-md": "^2.5.3"
The text was updated successfully, but these errors were encountered: