Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NavigationDrawer] - NavigationDrawer hides full-height drawers when defaultVisible is set to false #426

Closed
mctep opened this issue Jun 27, 2017 · 0 comments
Closed

[NavigationDrawer] - NavigationDrawer hides full-height drawers when defaultVisible is set to false #426

mctep opened this issue Jun 27, 2017 · 0 comments
Labels
bug
Milestone
v1.0.18

Comments

@mctep
Copy link

mctep commented Jun 27, 2017 •
edited

Description

If I use <NavigationDrawer defaultVisible={false} defaultMedia="desktop" desktopDrawerType="floating" /> menu is hidden on desktop version and it impossible to get access to it.

<NavigationDrawer
  className={cn('layout', this.props.className)}
  navItems={navItems}
  mobileDrawerType="temporary"
  tabletDrawerType="temporary"
  desktopDrawerType="floating"
  includeDrawerHeader={false}
  drawerClassName="md-toolbar-relative"
  toolbarTitle={this.renderToolbarTitle()}
  defaultVisible={false}
  defaultMedia="desktop"
/>

Version

  • React-MD 1.1
@mlaursen mlaursen added the bug label Jun 27, 2017
@mlaursen mlaursen changed the title NavigationDrawer defaultVisible={false} and defaultMedia="desktop" [NavigationDrawer] - NavigationDrawer defaultVisible={false} and defaultMedia="desktop" Jul 14, 2017
@mlaursen mlaursen changed the title [NavigationDrawer] - NavigationDrawer defaultVisible={false} and defaultMedia="desktop" [NavigationDrawer] - NavigationDrawer hides full-height drawers when defaultVisible is set to false Jul 14, 2017
@mlaursen mlaursen added this to the v1.0.18 milestone Aug 1, 2017
mlaursen added a commit that referenced this issue Aug 1, 2017
@mlaursen
Updated NavigationDrawer visible logic
28422c8 
The NavigationDrawer will now correctly set the internal visible state
to true when the drawer type is one of the permanent types even if the
defaultVisible prop is true.

Closes #426
@mlaursen mlaursen closed this as completed Aug 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v1.0.18
Development

No branches or pull requests
2 participants
@mctep @mlaursen