Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the Raising Dark Mode Functionality #860

mlaursen opened this issue Jan 8, 2020 · 0 comments

Implement the Raising Dark Mode Functionality #860

mlaursen opened this issue Jan 8, 2020 · 0 comments


Copy link

mlaursen commented Jan 8, 2020

The new dark theme specs are actually really nice and look much better than the current dark theme I implemented by default. The main problem with this is that I need to somehow link elevation and colors together and allow for conditionally switching between light and dark themes.

This issue is more just a reminder for myself to stop playing with implementing it for initial v2 release and it should be scoped for later. The two work-in-progress branches/commits are here:

I think I want to go more towards v1 of these two due to the colors not using opacities in that version. The "blockers" for this are that I might need to handle some of this in JS instead of CSS only, force a specific dark theme class name/media query, or something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

No branches or pull requests

1 participant