feat(typescript): support typescript version to v4.2.3#1099
Merged
Conversation
mlaursen
force-pushed
the
feature/support-typescript-2.4.3
branch
from
089b7f9 to
1f0c0a6
Compare
This _might_ be a breaking change for typescript consumers since they might also need to update their typescript version to v4.2.3 or whatever version added the type definitions for `ResizeObserver`. This also changed the `resize-observer-polyfill` dependency to `@juggle/resize-observer` since `resize-observer-polyfill` hasn't been updated since 2018 and the type definitions cause issues with the `lib.d.ts` definitions now provided for the `ResizeObserver`.
mlaursen
changed the title
mlaursen
force-pushed
the
feature/support-typescript-2.4.3
branch
from
1f0c0a6 to
725d1c9
Compare
Codecov Report
@@ Coverage Diff @@
## main #1099 +/- ##
==========================================
+ Coverage 78.58% 78.60% +0.01%
==========================================
Files 327 327
Lines 8924 8922 -2
Branches 2293 2291 -2
==========================================
Hits 7013 7013
+ Misses 1821 1819 -2
Partials 90 90
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This might be a breaking change for typescript consumers since they might also need to update their typescript version to v4.2.3 or whatever version added the type definitions for
ResizeObserver.This also changed the
resize-observer-polyfilldependency to@juggle/resize-observersinceresize-observer-polyfillhasn't been updated since 2018 and the type definitions cause issues with thelib.d.tsdefinitions now provided for theResizeObserver.