Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/form menu items #1123

Merged
merged 8 commits into from Apr 22, 2021
Merged

Feature/form menu items #1123

merged 8 commits into from Apr 22, 2021

Conversation

mlaursen
Copy link
Owner

@mlaursen mlaursen commented Apr 22, 2021

Description

This implements the MenuItemCheckbox, MenuItemRadio, MenuItemSwitch, and MenuItemInputToggle components to render accessible form controls within menus. This also refactored and exposed InputToggleIcon and SwitchTrack, but those are most likely just for internal usage.

Closes #882

@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2021

Codecov Report

Merging #1123 (d9695b7) into main (b278230) will increase coverage by 0.19%.
The diff coverage is 98.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1123      +/-   ##
==========================================
+ Coverage   79.83%   80.02%   +0.19%     
==========================================
  Files         328      334       +6     
  Lines        8886     8978      +92     
  Branches     2294     2314      +20     
==========================================
+ Hits         7094     7185      +91     
  Misses       1710     1710              
- Partials       82       83       +1     
Impacted Files Coverage Δ
packages/form/src/toggle/SwitchTrack.tsx 94.44% <94.44%> (ø)
packages/form/src/menu/MenuItemCheckbox.tsx 100.00% <100.00%> (ø)
packages/form/src/menu/MenuItemInputToggle.tsx 100.00% <100.00%> (ø)
packages/form/src/menu/MenuItemRadio.tsx 100.00% <100.00%> (ø)
packages/form/src/menu/MenuItemSwitch.tsx 100.00% <100.00%> (ø)
packages/form/src/toggle/InputToggle.tsx 98.03% <100.00%> (+0.03%) ⬆️
packages/form/src/toggle/InputToggleIcon.tsx 100.00% <100.00%> (ø)
packages/form/src/toggle/Switch.tsx 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b278230...d9695b7. Read the comment docs.

@mlaursen mlaursen merged commit d9695b7 into main Apr 22, 2021
@mlaursen mlaursen deleted the feature/form-menu-items branch April 22, 2021 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement MenuItemCheckbox, MenuItemRadio, and MenuItemSwitch Components
2 participants