New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/form menu items #1123
Merged
Merged
Feature/form menu items #1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
585818d
to
5cf4f8a
Compare
Codecov Report
@@ Coverage Diff @@
## main #1123 +/- ##
==========================================
+ Coverage 79.83% 80.02% +0.19%
==========================================
Files 328 334 +6
Lines 8886 8978 +92
Branches 2294 2314 +20
==========================================
+ Hits 7094 7185 +91
Misses 1710 1710
- Partials 82 83 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This implements the
MenuItemCheckbox
,MenuItemRadio
,MenuItemSwitch
, andMenuItemInputToggle
components to render accessible form controls within menus. This also refactored and exposedInputToggleIcon
andSwitchTrack
, but those are most likely just for internal usage.Closes #882