Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplifiying format and covering json and yml files #1227

Merged
merged 2 commits into from
Aug 16, 2021

Conversation

fjavierv
Copy link
Contributor

Hi @mlaursen, I am working with dependencies in your project and I notes that json files and ymI were not covered by prettier, so I change a little the configuration to avoid that.

After apply the new format configuration, I notes that you autogenerate tsconfig files, so I change also dev-utils code to prettify this code too.

I did execute this new config, because it change many files and it is my first pull request in react-md, I prefer that you apply that for me ;). The process to check this change could be (from the project root):

  • Apply the new format configuration:
    $> yarn format

  • Stage the changes to compare later:
    $> git add .

  • Built dev-utils:
    $> yarn build-dev-utils

  • Generate tsconfig files:
    $> yarn dev-utils configs

  • Check that there is not changes in the autogenerated files.

With the new format configuration the command "yarn format" take quite long time, but this command should not be execute frequently with editor integration and lint stage.

Please let me know if I have overlooked something.

@vercel
Copy link

vercel bot commented Aug 16, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mlaursen/react-md/D9Fni5B34j4yXbFFL4FqYTTWUFxE
✅ Preview: https://react-md-git-fork-fjavierv-prettier-mlaursen.vercel.app

@mlaursen
Copy link
Owner

Would you mind updating the .prettierignore to include:

 examples/create-react-app-typescript/README.md
 CHANGELOG.md
 **/CHANGELOG.md
+
+coverage
+node_modules
+
+/themes/*
+packages/*/es
+packages/*/lib
+packages/*/bin
+packages/*/dist
+packages/*/types
+packages/*/.next
+packages/documentation/src/constants/sassdoc
+packages/documentation/src/constants/sandboxes

I think I broke it up into the separate format commands to make sure that compiled files aren't included in the format command to speed it up, but I think adding these additional ignore rules should be about the same.

Once that gets added, it looks good to me since it'll be easier to update in the future. Thanks!

@mlaursen
Copy link
Owner

Thanks, looks good to me! I also updated the main branch to include the newly formatted files.

@fjavierv fjavierv deleted the prettier branch June 12, 2022 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants