New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify minimum Perl version in Makefile.PL. #12

Closed
wants to merge 1 commit into
base: dist
from

Conversation

Projects
None yet
2 participants
@monsieurp

monsieurp commented Jan 22, 2016

Hello

I'm participating in the CPAN Pull Request Challenge 2016 and p5-OptArgs is my
January assignment.

Your distribution is generating a warning 1 due to missing declaration of
the minimum Perl version OptArgs can support. As advised, I've run
Perl::MinimumVersion against your modules and the outcome was Perl 5.6.

Cheers

@mlawren

This comment has been minimized.

Show comment
Hide comment
@mlawren

mlawren Jan 25, 2016

Owner

Thanks for taking part in the PRC! I have cherry-picked your change into the "devel" branch and it will appear in the next stable release of OptArgs.

I suspect that Niel is doing some kind of automated recognition of pull request merges ... so you might need to let him know that the pull request was successful manually...

Owner

mlawren commented Jan 25, 2016

Thanks for taking part in the PRC! I have cherry-picked your change into the "devel" branch and it will appear in the next stable release of OptArgs.

I suspect that Niel is doing some kind of automated recognition of pull request merges ... so you might need to let him know that the pull request was successful manually...

@monsieurp

This comment has been minimized.

Show comment
Hide comment
@monsieurp

monsieurp Jan 25, 2016

Thank you. I didn't get a notification that you had replied to my PR already. I've let Neil know so I guess we're done here 😄 Thanks again! 👍

monsieurp commented Jan 25, 2016

Thank you. I didn't get a notification that you had replied to my PR already. I've let Neil know so I guess we're done here 😄 Thanks again! 👍

@monsieurp monsieurp closed this Jan 25, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment