Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch exceptions when creating/deleting clusters #276

Merged
merged 1 commit into from Oct 30, 2020

Conversation

ehoelzl
Copy link
Contributor

@ehoelzl ehoelzl commented Oct 9, 2020

Closes #94

@codecov
Copy link

codecov bot commented Oct 9, 2020

Codecov Report

Merging #276 into develop will increase coverage by 0.00%.
The diff coverage is 37.50%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #276   +/-   ##
========================================
  Coverage    26.08%   26.08%           
========================================
  Files          100      100           
  Lines         6203     6217   +14     
========================================
+ Hits          1618     1622    +4     
- Misses        4585     4595   +10     
Impacted Files Coverage Δ
mlbench_core/cli/gcloud_utils.py 52.94% <37.50%> (-3.88%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bb8e06...583ffe3. Read the comment docs.

@ehoelzl ehoelzl merged commit 5b00c2e into develop Oct 30, 2020
@ehoelzl ehoelzl deleted the Fix-clusterzone-bug branch October 30, 2020 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cluster creation/deletion errors with non-default zone
2 participants