Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increasing unit test coverage #487

Merged
merged 47 commits into from
Sep 7, 2022

Conversation

sarthakpati
Copy link
Collaborator

@sarthakpati sarthakpati commented Sep 5, 2022

Fixes #N.A.

Proposed Changes

  • increasing test coverage
  • one typo fixed
  • using vips for resizing image in CI because it needed less resources compared to SimleITK/OpenCV/PIL/skimage - still won't use it in part of main repo
  • "__main__" function in inference_loop is not needed, since InferenceManager is invoked from main_cli
  • hash updated for dicomanonymizer which includes fix for generating random UID

Checklist

  • I have read the CONTRIBUTING guide
  • My PR is based from the current GaNDLF master
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change
  • Function/class source code documentation added/updated
  • Code has been blacked for style consistency
  • If applicable, version information has been updated in GANDLF/version.py
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file
  • Usage documentation has been updated, if appropriate
  • History has been updated, if appropriate
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3,4]

@sarthakpati sarthakpati marked this pull request as draft September 5, 2022 08:33
@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Merging #487 (2706321) into master (b0f91d0) will increase coverage by 0.60%.
The diff coverage is 93.67%.

@@            Coverage Diff             @@
##           master     #487      +/-   ##
==========================================
+ Coverage   92.47%   93.07%   +0.60%     
==========================================
  Files         105      104       -1     
  Lines        6459     6472      +13     
==========================================
+ Hits         5973     6024      +51     
+ Misses        486      448      -38     
Flag Coverage Δ
unittests 93.07% <93.67%> (+0.60%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
testing/test_full.py 97.97% <93.05%> (-0.09%) ⬇️
GANDLF/compute/inference_loop.py 91.39% <100.00%> (+7.14%) ⬆️
GANDLF/compute/training_loop.py 82.19% <100.00%> (ø)
GANDLF/data/post_process/tensor.py 100.00% <100.00%> (+13.33%) ⬆️
testing/conftest.py
...NDLF/data/preprocessing/template_matching/utils.py 97.67% <0.00%> (+2.32%) ⬆️
GANDLF/data/post_process/morphology.py 100.00% <0.00%> (+3.84%) ⬆️
GANDLF/training_manager.py 88.99% <0.00%> (+4.58%) ⬆️
GANDLF/cli/main_run.py 84.61% <0.00%> (+20.51%) ⬆️
GANDLF/anonymize/__init__.py 100.00% <0.00%> (+26.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sarthakpati sarthakpati marked this pull request as ready for review September 5, 2022 22:27
@sarthakpati sarthakpati changed the title Increasing test coverage Increasing unit test coverage Sep 6, 2022
@sarthakpati sarthakpati merged commit 01cc320 into mlcommons:master Sep 7, 2022
@sarthakpati sarthakpati deleted the increasing_test_coverage branch September 7, 2022 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants