From 3095cc442ae9225b610fda6f5bab831ac4ee0e7a Mon Sep 17 00:00:00 2001 From: Priya Kasimbeg Date: Tue, 10 Oct 2023 23:54:36 +0000 Subject: [PATCH 1/3] set criteo test targets based on external runs --- algorithmic_efficiency/workloads/criteo1tb/workload.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/algorithmic_efficiency/workloads/criteo1tb/workload.py b/algorithmic_efficiency/workloads/criteo1tb/workload.py index ef971bb75..1d8d670f1 100644 --- a/algorithmic_efficiency/workloads/criteo1tb/workload.py +++ b/algorithmic_efficiency/workloads/criteo1tb/workload.py @@ -35,14 +35,14 @@ def has_reached_validation_target(self, eval_result: Dict[str, @property def validation_target_value(self) -> float: - return 0.123649 + return 0.12364747752808988 def has_reached_test_target(self, eval_result: Dict[str, float]) -> bool: return eval_result['test/loss'] < self.test_target_value @property def test_target_value(self) -> float: - return 0.126060 + return 0.1267424139736351 @property def loss_type(self) -> spec.LossType: From 36b33dc00f2e6c84dabcb91ed3405bb530b3274b Mon Sep 17 00:00:00 2001 From: Priya Kasimbeg Date: Tue, 10 Oct 2023 23:59:59 +0000 Subject: [PATCH 2/3] rounding --- algorithmic_efficiency/workloads/criteo1tb/workload.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/algorithmic_efficiency/workloads/criteo1tb/workload.py b/algorithmic_efficiency/workloads/criteo1tb/workload.py index 1d8d670f1..2c8ddc160 100644 --- a/algorithmic_efficiency/workloads/criteo1tb/workload.py +++ b/algorithmic_efficiency/workloads/criteo1tb/workload.py @@ -35,14 +35,14 @@ def has_reached_validation_target(self, eval_result: Dict[str, @property def validation_target_value(self) -> float: - return 0.12364747752808988 + return 0.123647 def has_reached_test_target(self, eval_result: Dict[str, float]) -> bool: return eval_result['test/loss'] < self.test_target_value @property def test_target_value(self) -> float: - return 0.1267424139736351 + return 0.126742 @property def loss_type(self) -> spec.LossType: From 58d0ef3b9d5cfadf3183b737bbd61d364c10d7c2 Mon Sep 17 00:00:00 2001 From: Priya Kasimbeg Date: Wed, 11 Oct 2023 00:10:41 +0000 Subject: [PATCH 3/3] update --- algorithmic_efficiency/workloads/criteo1tb/workload.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/algorithmic_efficiency/workloads/criteo1tb/workload.py b/algorithmic_efficiency/workloads/criteo1tb/workload.py index 2c8ddc160..13bd308fb 100644 --- a/algorithmic_efficiency/workloads/criteo1tb/workload.py +++ b/algorithmic_efficiency/workloads/criteo1tb/workload.py @@ -35,14 +35,14 @@ def has_reached_validation_target(self, eval_result: Dict[str, @property def validation_target_value(self) -> float: - return 0.123647 + return 0.123735 def has_reached_test_target(self, eval_result: Dict[str, float]) -> bool: return eval_result['test/loss'] < self.test_target_value @property def test_target_value(self) -> float: - return 0.126742 + return 0.126041 @property def loss_type(self) -> spec.LossType: