From 323ab515b9e29521a2775d68b8145aa8cfb8b88c Mon Sep 17 00:00:00 2001 From: ANANDHU S <71482562+anandhu-eng@users.noreply.github.com> Date: Wed, 16 Jul 2025 15:32:53 +0530 Subject: [PATCH 1/3] Update PR checklist --- .github/pull_request_template.md | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 0c9be0346..cd198b225 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,6 +1,23 @@ ### ๐Ÿงพ PR Checklist - [ ] Target branch is `dev` -- [ ] Changes have been tested locally + +### โœ… Testing & CI +- [ ] I have tested the changes in my local environment. +- [ ] If not tested locally, I have clearly explained why in the PR description. +- [ ] The change includes a GitHub Action to test the script(if it is possible to be added). +- [ ] No existing GitHub Actions are failing because of this change. + +### ๐Ÿ“ File Hygiene & Output Handling +- [ ] No unintended files (e.g., logs, cache, temp files, __pycache__, output folders) are committed. + +### ๐Ÿ“ Comments & Communication +- [ ] Proper inline comments are added to explain important or non-obvious changes. +- [ ] PR title and description clearly state what the PR does and why. +- [ ] Related issues (if any) are properly referenced (`Fixes #`, `Related to #`, etc.). + +### ๐Ÿ›ก๏ธ Safety & Security +- [ ] No secrets or credentials are committed. +- [ ] Paths, shell commands, and environment handling are safe and portable. ๐Ÿ“Œ Note: PRs must be raised against `dev`. Do not commit directly to `main`. From 0fa4b63f420202eb00538d41fdd4c972dae2dbc4 Mon Sep 17 00:00:00 2001 From: ANANDHU S <71482562+anandhu-eng@users.noreply.github.com> Date: Wed, 16 Jul 2025 15:42:33 +0530 Subject: [PATCH 2/3] Update pull_request_template.md --- .github/pull_request_template.md | 24 +++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index cd198b225..aa4ef8948 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -2,22 +2,24 @@ - [ ] Target branch is `dev` +๐Ÿ“Œ Note: PRs must be raised against `dev`. Do not commit directly to `main`. + ### โœ… Testing & CI -- [ ] I have tested the changes in my local environment. -- [ ] If not tested locally, I have clearly explained why in the PR description. -- [ ] The change includes a GitHub Action to test the script(if it is possible to be added). -- [ ] No existing GitHub Actions are failing because of this change. +- [ ] Have tested the changes in my local environment, else have properly conveyed in the PR description +- [ ] The change includes a GitHub Action to test the script(if it is possible to be added) +- [ ] No existing GitHub Actions are failing because of this change ### ๐Ÿ“ File Hygiene & Output Handling -- [ ] No unintended files (e.g., logs, cache, temp files, __pycache__, output folders) are committed. +- [ ] No unintended files (e.g., logs, cache, temp files, __pycache__, output folders) are committed ### ๐Ÿ“ Comments & Communication -- [ ] Proper inline comments are added to explain important or non-obvious changes. -- [ ] PR title and description clearly state what the PR does and why. -- [ ] Related issues (if any) are properly referenced (`Fixes #`, `Related to #`, etc.). +- [ ] Proper inline comments are added to explain important or non-obvious changes +- [ ] PR title and description clearly state what the PR does and why +- [ ] Related issues (if any) are properly referenced (`Fixes #`, `Related to #`, etc.) +- [ ] All reviewer feedback has been addressed ### ๐Ÿ›ก๏ธ Safety & Security -- [ ] No secrets or credentials are committed. -- [ ] Paths, shell commands, and environment handling are safe and portable. +- [ ] No secrets or credentials are committed +- [ ] Paths, shell commands, and environment handling are safe and portable + -๐Ÿ“Œ Note: PRs must be raised against `dev`. Do not commit directly to `main`. From 1abc54f53642f2c0d2d493cc3e7e618d64df2051 Mon Sep 17 00:00:00 2001 From: ANANDHU S <71482562+anandhu-eng@users.noreply.github.com> Date: Wed, 16 Jul 2025 23:17:41 +0530 Subject: [PATCH 3/3] Update pull_request_template.md --- .github/pull_request_template.md | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index aa4ef8948..3e70589a3 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -5,8 +5,6 @@ ๐Ÿ“Œ Note: PRs must be raised against `dev`. Do not commit directly to `main`. ### โœ… Testing & CI -- [ ] Have tested the changes in my local environment, else have properly conveyed in the PR description -- [ ] The change includes a GitHub Action to test the script(if it is possible to be added) - [ ] No existing GitHub Actions are failing because of this change ### ๐Ÿ“ File Hygiene & Output Handling