Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

firebugx.js won't detect Firebug 1.9 - with patch #259

Closed
rohanc opened this Issue · 2 comments

3 participants

@rohanc

The Firebug detection code in firebugx.js is not effective if you upgrade to Firebug 1.9 (currently in beta). You end up with console logging disabled, even though the Firebug console is available.

I use Slickgrid 2.0 alpha, but I notice the same problem code in the master branch.

Solution: On my system, I changed the test in firebugx.js from this:

if (!("console" in window) || !("firebug" in console))

to this:

if (typeof console === "undefined" || typeof console.log === "undefined") {

I made some comments about this in the Firebug bug database, which documents their decision to make it impossible to detect Firebug:

http://code.google.com/p/fbug/issues/detail?id=4772

Rohan

@simonlindholm

I'll note that quite a lot of people are complaining about this on the Firebug bug tracker.

@mleibman mleibman referenced this issue from a commit
@mleibman Fixed issue #259 - updated console stub to work with Firebug 1.9 and …
…deleted unused Firebug Lite script.
b9592ca
@mleibman
Owner

Thanks.
Fixed in b9592ca.

@mleibman mleibman closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.