New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Safari 6 toString() defaultFormatter bug #472

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@jaywilliams

jaywilliams commented Oct 18, 2012

On Safari 6 in Lion, the toString() method will fail with the message TypeError: Type error when parsing certain numeric data if the Error Console is not open. If the Error Console is open, the error does not occur. This bug doesn't occur in Safari 5.

Due to the strangeness of this bug, I'm assuming it's browser specific. To get around this bug, I used string concatenation, rather than the toString() method.

Fix Safari 6 toString() defaultFormatter() bug
On Safari 6 in Lion, the toString() method will fail on numeric data if
the Error Console is not open. By using string concatenation, this gets
around this strange Safari bug.
@pake007

This comment has been minimized.

Show comment
Hide comment
@pake007

pake007 Jan 31, 2013

Thanks for the commit!

pake007 commented on 6b8de21 Jan 31, 2013

Thanks for the commit!

This comment has been minimized.

Show comment
Hide comment
@pake007

pake007 Jan 31, 2013

I also meet this problem.

pake007 replied Jan 31, 2013

I also meet this problem.

@blicksky

This comment has been minimized.

Show comment
Hide comment
@blicksky

blicksky Feb 27, 2013

I found that simply wrapping the toString() call in a try/catch block seems to have the same effect as opening the error console or developer tools, and seems to avoid the issue.

blicksky commented Feb 27, 2013

I found that simply wrapping the toString() call in a try/catch block seems to have the same effect as opening the error console or developer tools, and seems to avoid the issue.

@Olegas

This comment has been minimized.

Show comment
Hide comment
@Olegas

Olegas Apr 30, 2013

@jaywilliams I've expiriencing this bug on mobile Safari on iOS. Can you reproduce it with some "localized" code, not in a real app?
Trying to reproduce too, but failed for now. Reproduced not stable only in my app/site (not related to SlickGrid).

Olegas commented Apr 30, 2013

@jaywilliams I've expiriencing this bug on mobile Safari on iOS. Can you reproduce it with some "localized" code, not in a real app?
Trying to reproduce too, but failed for now. Reproduced not stable only in my app/site (not related to SlickGrid).

@mleibman

This comment has been minimized.

Show comment
Hide comment
@mleibman

mleibman Apr 30, 2013

Owner

Merged in e016c9f

Owner

mleibman commented Apr 30, 2013

Merged in e016c9f

@mleibman mleibman closed this Apr 30, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment