Handle links in app #239
Merged
Handle links in app #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ented - doing that allowed us to push/pop anything we want to the navigation stack - added new link handling, now if a link looks even remotely "sus" I will ask Lemmy's servers if they know it, if they do know it: We push the appropriate object to the navigation stack if they don't know about it and it's an HTTP link, kept the old behavior otherwise I let the system try to open it (which is way nicer than telling the user "it's not supported" especially for mailto: links XD
…in there SwiftUI should pick up on it better (that solved a bug where the upvote/downvotes weren't updating correctly sometimes - updated every place that expects APIPostView.id == APIPostView.post.id to reference the correct id (usually .post.id) - Since ExpandedPost is not more independent made the postView within it it's state
…n-app # Conflicts: # Mlem.xcodeproj/project.pbxproj
…n-app # Conflicts: # Mlem/Views/Tabs/Posts/Components/Post/Components/Community View/Community Search/Community Search View.swift
|
Nice! I'll get a look at this but likely tomorrow at the earliest, if you're looking for the matrix chat here's a link which I think should work; https://matrix.to/#/%23MlemApp%3Amatrix.org Once there we should be to get you into the dev chat if you like 👍 |
|
Ahaha I’m already there (General and recruitment) and just saw the invite to dev,, I’ll try to be just as active there as I am here |
|
I RPReplay_Final1687607587.mov'd say it's looking pretty good |
Had to commit some more crims to keep the SwiftUI state all synced up nicely Made sure to noty double up on the NavigationStack in the user page since it really crashs everything for some reason
|
I'd say I have to agree with your statement |
BrooklynMan
approved these changes
Jun 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Choose one of the following two options:
Choose one of the following two options:
Pull Request Information
About this Pull Request
The gist is that if you click a link in a post that looks like it's another Lemmy post/community/user we'll open that in app and not in Safari! but here're the more detailed change log since it was no easy task:
if they don't know about it and it's an HTTP link, kept the old behavior
otherwise I let the system try to open it (which is way nicer than telling the user "it's not supported" especially for mailto: links XD
Screenshots and Videos
IMG_7203.mov
(It's less helpful since you don't see where I'm tapping 😅 but I hope you understood from context that Im pressing on each individual representation of these links)
Additional Context