Skip to content

Conversation

JakeShirley
Copy link
Member

Checklist

  • I have described what this PR contains

Choose one of the following two options:

    • This PR does not introduce major changes
    • This PR introduces major changes, and I have consulted the Mlem Development Matrix room

Choose one of the following two options:

    • This PR does not change the UI in any way
    • This PR adds new UI elements / changes the UI, and I have attached pictures or videos of the new / changed UI elements

Pull Request Information

About this Pull Request

This PR implements the Profile tab!

Features:

  • "Overview" tab with a mix of posts/comments
  • "Comments" tab for just comments
  • "Posts" tab for just posts
  • "Saved" tab which only shows up in your own profile and shows your saved comments and posts

You can click on other people's profile and see them as well.

NOTE: I did not implement streaming down of pages of content. That will come in a follow up PR. We will need to clean up how I am fetching data in order to do that.

Screenshots and Videos

Additional Context

We also had a request on /c/mlemapp to add an option to hide the username from the navigation bar at the bottom, so I added that.

tht7
tht7 previously approved these changes Jun 25, 2023
Copy link
Contributor

@tht7 tht7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall! I have some minor nitpicks but nothing much, aside from maybe agreeing with @mormaer over nested iteration

@tht7
Copy link
Contributor

tht7 commented Jun 26, 2023

Wait wait wait
In the last few PRs we swapped the project to using the new NagivationStack style that’s based on values and not destination views (new in iOs 16)

I think we need to be consistent on it
Please look at how it was done (it’s pretty well encapsulated in the handle links viewModifiers for convince - files placed in the extensions folder, I would be more specific but I’m on mobile so you’ll have to wait until I’m home)

@JakeShirley
Copy link
Member Author

Will do @tht7, thanks for the insight!

@JakeShirley
Copy link
Member Author

@tht7 let me know what you think.

@BrooklynMan BrooklynMan merged commit bd387c3 into mlemgroup:master Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants