-
Notifications
You must be signed in to change notification settings - Fork 1
Implemented Profile Tab #269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great overall! I have some minor nitpicks but nothing much, aside from maybe agreeing with @mormaer over nested iteration
...Tabs/Posts/Components/Post/Components/Community View/Post Item/Lazy Load Expanded Post.swift
Outdated
Show resolved
Hide resolved
5626c1d to
3d2ee9c
Compare
|
Wait wait wait I think we need to be consistent on it |
|
Will do @tht7, thanks for the insight! |
3d2ee9c to
d8ac44c
Compare
|
@tht7 let me know what you think. |
Checklist
Choose one of the following two options:
Choose one of the following two options:
Pull Request Information
About this Pull Request
This PR implements the Profile tab!
Features:
You can click on other people's profile and see them as well.
NOTE: I did not implement streaming down of pages of content. That will come in a follow up PR. We will need to clean up how I am fetching data in order to do that.
Screenshots and Videos
Additional Context
We also had a request on /c/mlemapp to add an option to hide the username from the navigation bar at the bottom, so I added that.