Add Ruby versions to build matrix#18
Closed
shanecav84 wants to merge 1 commit intomlen:masterfrom
shanecav84:add_ruby_versions_to_build_matrix
Closed
Add Ruby versions to build matrix#18shanecav84 wants to merge 1 commit intomlen:masterfrom shanecav84:add_ruby_versions_to_build_matrix
shanecav84 wants to merge 1 commit intomlen:masterfrom
shanecav84:add_ruby_versions_to_build_matrix
Conversation
AlexWayfer
reviewed
Jun 24, 2019
| @@ -6,5 +6,7 @@ rvm: | |||
| - 2.2 | |||
| - 2.3 | |||
There was a problem hiding this comment.
Also, I think, you can drop 2.3 and earlier, because the maintenance (even security) has been ended: https://www.ruby-lang.org/en/news/2019/03/31/support-of-ruby-2-3-has-ended/
Author
|
sequel is still supporting 1.9.2. I presume we don't want to drop Ruby versions until sequel does. |
As you want, just a suggestion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.