Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 2 support from MLflow in MLflow 1.8.0 #2522

Open
smurching opened this issue Mar 2, 2020 · 3 comments
Open

Drop Python 2 support from MLflow in MLflow 1.8.0 #2522

smurching opened this issue Mar 2, 2020 · 3 comments

Comments

@smurching
Copy link
Contributor

@smurching smurching commented Mar 2, 2020

Proposal

The upcoming MLflow release (1.7.0, to be published in the next week), will ship with a deprecation warning indicating that Python 2 support will be dropped in a future release, in light of Python 2 reaching end-of-life in January 2020.

Given that Python 2 is EOL, we should drop Python 2 support in MLflow in an upcoming release, e.g. the MLflow 1.8.0 release, with an expected release date around end of March 2020.

This would bring a number of benefits, e.g. significantly reducing MLflow's maintenance burden (no need to write code / tests / manage test environments across increasingly divergent Python 2 & Python 3 lines), and speeding up CI times.

Things to note:

  • Python 2 workflows that depend on the "latest" MLflow version will still work (e.g. workflows that depend on the mlflow PyPI library but don't specify a version). These workflows will simply use MLflow 1.7.0. Similarly, Python 2 workflows depending on MLflow versions < 1.7.0 will still work.
  • Python 2 users will not have access to new MLflow features & most bug fixes. This aligns with the strategy of other open-source libraries, as ML libraries like NumpyPandasScikit-learn, and TensorFlow have already dropped support.
  • We may, in exceptional cases, consider backporting critical security fixes to the 1.7 branch and making 1.7.x patch releases for Python 2 users. We don't expect to regularly publish 1.7.x MLflow releases - Python itself has already stopped accepting security fixes (as of Jan 1, 2020) for Python 2.

Feedback Welcome

Please reply to this issue with any questions or thoughts - we're open to delaying dropping Python 2 support, but would strongly prefer to stick to the end-of-March timeline if at all possible.

Barring major objections, we'll go ahead & publish an official announcement the week of March 8 - thank you!

@smurching

This comment has been minimized.

Copy link
Contributor Author

@smurching smurching commented Mar 9, 2020

Update on this, looks like we're cleared to move forward with dropping Python 2 support (was unable to find any strong pushback against it), will publish a formal announcement on mlflow.org and the users mailing list. Thanks all!

Edit: #2538 is also blocked on #2534 which is blocked on this

@PhilipMay

This comment has been minimized.

Copy link

@PhilipMay PhilipMay commented Mar 11, 2020

I do not care about python 2. Dropping it is very welcome.

@keigohtr

This comment has been minimized.

Copy link
Contributor

@keigohtr keigohtr commented Mar 24, 2020

Can anyone review and retest this PR? -> #2538

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.