Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mlflow/R] Minor fixes. #1098

Merged
merged 7 commits into from Apr 8, 2019
Merged

Conversation

@tomasatdatabricks
Copy link
Contributor

tomasatdatabricks commented Apr 4, 2019

  1. Use MLFLOW_CONDA_HOME if set.
  2. Do not turn artifact uris to local path when listing experiments. Python does not do it, it can be confusing.
  3. When fetching experiment by name, check if there are any experiments (currently this call fails if there are no experiments.).
tomasatdatabricks and others added 7 commits Mar 15, 2019
Copy link
Contributor

smurching left a comment

Had one micronit (a missing newline at EOF). I took the liberty of fixing it (pushing to your branch), LGTM once tests pass :)

Copy link
Contributor

kevinykuo left a comment

LGTM!

@kevinykuo kevinykuo merged commit 65bd5d9 into mlflow:master Apr 8, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.