Skip to content

Revert "Fix response handling in log_spans (#18280)" - #18349

Merged
serena-ruan merged 3 commits into
masterfrom
pr-18341
Oct 16, 2025
Merged

Revert "Fix response handling in log_spans (#18280)"#18349
serena-ruan merged 3 commits into
masterfrom
pr-18341

Conversation

@serena-ruan

@serena-ruan serena-ruan commented Oct 16, 2025

Copy link
Copy Markdown
Collaborator
🛠 DevTools 🛠

Open in GitHub Codespaces

Install mlflow from this PR

# mlflow
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/18349/merge
# mlflow-skinny
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/18349/merge#subdirectory=libs/skinny

For Databricks, use the following command:

%sh curl -LsSf https://raw.githubusercontent.com/mlflow/mlflow/HEAD/dev/install-skinny.sh | sh -s pull/18349/merge

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

I accidentally dropped #18341 by force pushing to master branch, adding it back

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/tracking: Tracking Service, tracking client APIs, autologging
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflows
  • area/gateway: MLflow AI Gateway client APIs, server, and third-party integrations
  • area/prompts: MLflow prompt engineering features, prompt templates, and prompt management
  • area/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionality
  • area/projects: MLproject format, project running backends
  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

Yes should be selected for bug fixes, documentation updates, and other small changes. No should be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.

What is a minor/patch release?
  • Minor release: a release that increments the second part of the version number (e.g., 1.2.0 -> 1.3.0).
    Bug fixes, doc updates and new features usually go into minor releases.
  • Patch release: a release that increments the third part of the version number (e.g., 1.2.0 -> 1.2.1).
    Bug fixes and doc updates usually go into patch releases.
  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)

This reverts commit 6da0717.

Signed-off-by: B-Step62 <yuki.watanabe@databricks.com>
Signed-off-by: B-Step62 <yuki.watanabe@databricks.com>
Signed-off-by: B-Step62 <yuki.watanabe@databricks.com>
@github-actions github-actions Bot added v3.5.0 rn/none List under Small Changes in Changelogs. labels Oct 16, 2025
@serena-ruan serena-ruan added rn/none List under Small Changes in Changelogs. and removed rn/none List under Small Changes in Changelogs. labels Oct 16, 2025
@serena-ruan
serena-ruan merged commit 9a8a940 into master Oct 16, 2025
61 of 100 checks passed
@serena-ruan
serena-ruan deleted the pr-18341 branch October 16, 2025 09:38
serena-ruan added a commit to serena-ruan/mlflow that referenced this pull request Oct 16, 2025
)

Signed-off-by: B-Step62 <yuki.watanabe@databricks.com>
Co-authored-by: B-Step62 <yuki.watanabe@databricks.com>
serena-ruan added a commit that referenced this pull request Oct 16, 2025
Signed-off-by: B-Step62 <yuki.watanabe@databricks.com>
Co-authored-by: B-Step62 <yuki.watanabe@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rn/none List under Small Changes in Changelogs. v3.5.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants