Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependency-installation bug in Java MLflow model scoring server #1913

Merged
merged 2 commits into from Oct 15, 2019

Conversation

smurching
Copy link
Collaborator

What changes are proposed in this pull request?

Fixes a bug (#1906) where we currently don't install dependencies of the Java MLflow model scoring server within the docker image for the server

How is this patch tested?

Manually verified that I was able to run an updated image built from this PR locally & on SageMaker

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

Fixed a dependency-installation bug that prevented running the Java MLflow model scoring server against a docker image built via mlflow sagemaker build-and-push-container.

What component(s) does this PR affect?

  • UI
  • CLI
  • API
  • REST-API
  • Examples
  • Docs
  • Tracking
  • Projects
  • Artifacts
  • Models
  • Scoring
  • Serving
  • R
  • Java
  • Python

How should the PR be classified in the release notes? Choose one:

  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

@smurching smurching added the rn/bug-fix Mention under Bug Fixes in Changelogs. label Oct 9, 2019
@@ -71,7 +71,11 @@ def _get_mlflow_install_step(dockerfile_context_dir, mlflow_home):
"RUN mvn "
" --batch-mode dependency:copy"
" -Dartifact=org.mlflow:mlflow-scoring:{version}:jar"
" -DoutputDirectory=/opt/java/jars"
" -DoutputDirectory=/opt/java/jars\n"
"RUN cp /opt/java/mlflow-scoring-{version}.pom /opt/java/pom.xml\n"
Copy link
Collaborator Author

@smurching smurching Oct 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set up a /opt/java/pom.xml file so that we can invoke mvn copy-dependencies (which transitively downloads dependencies of the pom.xml, see docs) from the /opt/java directory (treat /opt/java as a mvn project)

Copy link
Contributor

@tomasatdatabricks tomasatdatabricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks for the fix.

@smurching smurching merged commit 429d581 into mlflow:master Oct 15, 2019
avflor pushed a commit to avflor/mlflow that referenced this pull request Aug 22, 2020
…lflow#1913)

Fixed a dependency-installation bug that prevented running the Java MLflow model scoring server against a docker image built via mlflow sagemaker build-and-push-container.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn/bug-fix Mention under Bug Fixes in Changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants