Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression in mlflow_create_experiment() #576

Merged
merged 2 commits into from Oct 2, 2018
Merged

Fix regression in mlflow_create_experiment() #576

merged 2 commits into from Oct 2, 2018

Conversation

javierluraschi
Copy link
Collaborator

I believe we should take this fix if we are requested to make a change while submitting to CRAN.

CC: @kevinykuo @tomasatdatabricks

@andrewmchen andrewmchen added the language/r R APIs and clients label Oct 1, 2018
tomasatdatabricks
tomasatdatabricks reviewed Oct 2, 2018
View reviewed changes
Copy link
Contributor

@tomasatdatabricks tomasatdatabricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but do we need to add a test?

@javierluraschi
Copy link
Collaborator Author

Note: The tests/keras/test_keras_model_export.py::test_model_save_load is failing but this is the case for all other jobs, last commit affects only R tests.

@javierluraschi javierluraschi merged commit ccc76ef into mlflow:master Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomasatdatabricks tomasatdatabricks tomasatdatabricks left review comments

Assignees
No one assigned
Labels
language/r R APIs and clients
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@javierluraschi @tomasatdatabricks @andrewmchen