-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disallow local source for model version #7908
Conversation
Signed-off-by: harupy <hkawamura0130@gmail.com>
Documentation preview for 31876fd will be available here when this CircleCI job completes successfully. More info
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @harupy !
Signed-off-by: harupy <hkawamura0130@gmail.com>
Signed-off-by: harupy <hkawamura0130@gmail.com>
* Disallow local source for model version Signed-off-by: harupy <hkawamura0130@gmail.com> * Fix tests Signed-off-by: harupy <hkawamura0130@gmail.com> * Fix is_local_uri Signed-off-by: harupy <hkawamura0130@gmail.com> * Use runs URI Signed-off-by: harupy <hkawamura0130@gmail.com> * Fix tests Signed-off-by: harupy <hkawamura0130@gmail.com> --------- Signed-off-by: harupy <hkawamura0130@gmail.com>
As of MLflow 2.2.1 this is a major breaking change that breaks all previous code that calls MlflowClient.create_model_version() on a local tracking server. It has broken all the tests in https://github.com/mlflow/mlflow-export-import/tree/master/tests. How do I then create a model version on a local (test) tracking server? |
This change broke most of my models, where is the documentation about this? I use a network drive to save the artifacts. |
@harupy Thanks for the fix, my organisation still uses mlflow 1.29 as we didn't evaluate the cost of handling the breaking changes between 1.30 and 2.0.1 for our clients, and the 1.30 has a bug that was only solved in 2.0.1: We need to get this patch though, can you consider backporting it on the 1.29 version, along with https://github.com/mlflow/mlflow/pull/7965/files ? I can do the PR but I'd like to be sure you agree to republish a 1.29.1 version with the fix |
Signed-off-by: j.cuquemelle <j.cuquemelle@criteo.com>
Related Issues/PRs
#7884What changes are proposed in this pull request?
Disallows local source for model version.
How is this patch tested?
Does this PR change the documentation?
Release Notes
Is this a user-facing change?
(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/artifacts
: Artifact stores and artifact loggingarea/build
: Build and test infrastructure for MLflowarea/docs
: MLflow documentation pagesarea/examples
: Example codearea/model-registry
: Model Registry service, APIs, and the fluent client calls for Model Registryarea/models
: MLmodel format, model serialization/deserialization, flavorsarea/recipes
: Recipes, Recipe APIs, Recipe configs, Recipe Templatesarea/projects
: MLproject format, project running backendsarea/scoring
: MLflow Model server, model deployment tools, Spark UDFsarea/server-infra
: MLflow Tracking server backendarea/tracking
: Tracking Service, tracking client APIs, autologgingInterface
area/uiux
: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/docker
: Docker use across MLflow's components, such as MLflow Projects and MLflow Modelsarea/sqlalchemy
: Use of SQLAlchemy in the Tracking Service or Model Registryarea/windows
: Windows supportLanguage
language/r
: R APIs and clientslanguage/java
: Java APIs and clientslanguage/new
: Proposals for new client languagesIntegrations
integrations/azure
: Azure and Azure ML integrationsintegrations/sagemaker
: SageMaker integrationsintegrations/databricks
: Databricks integrationsHow should the PR be classified in the release notes? Choose one:
rn/breaking-change
- The PR will be mentioned in the "Breaking Changes" sectionrn/none
- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/feature
- A new user-facing feature worth mentioning in the release notesrn/bug-fix
- A user-facing bug fix worth mentioning in the release notesrn/documentation
- A user-facing documentation change worth mentioning in the release notes