-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix some lfi issues #8648
fix some lfi issues #8648
Conversation
Signed-off-by: Serena Ruan <serena.rxy@gmail.com>
|
Documentation preview for e46ddb1 will be available here when this CircleCI job completes successfully. More info
|
Co-authored-by: Harutaka Kawamura <hkawamura0130@gmail.com> Signed-off-by: Serena Ruan <82044803+serena-ruan@users.noreply.github.com>
Signed-off-by: Serena Ruan <serena.rxy@gmail.com>
Signed-off-by: Serena Ruan <serena.rxy@gmail.com>
| response = requests.post( | ||
| f"{mlflow_client.tracking_uri}/api/2.0/mlflow/model-versions/create", | ||
| json={ | ||
| "name": name, | ||
| "source": "mlflow-artifacts://host:9000/models/..%2f..%2fartifacts", | ||
| "run_id": run.info.run_id, | ||
| }, | ||
| ) | ||
| assert response.status_code == 400 | ||
| assert "If supplying a source as an http, https," in response.json()["message"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also add test cases for multiple slashes in the URL and many dots (e.g. 4 dots)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Multiple slashes will be converted to single slash, and it should work fine (there's a test case already). For many dots, the current logic is still passing because it's not violating any rules, but the url "xxxx/..../" is not a correct path. Should we just add limitation to converting more than two dots into two dots? Or not allowing them at all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think multiple dots is a valid filename, so we should allow it - just want to make sure that there isn't an LFI with that. I think it's fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once #8648 (comment) is addressed. Thanks @serena-ruan !
Signed-off-by: Serena Ruan <serena.rxy@gmail.com>
Co-authored-by: Harutaka Kawamura <hkawamura0130@gmail.com> Signed-off-by: Serena Ruan <82044803+serena-ruan@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* fix some lfi issues Signed-off-by: Serena Ruan <serena.rxy@gmail.com> * Update mlflow/server/handlers.py Co-authored-by: Harutaka Kawamura <hkawamura0130@gmail.com> Signed-off-by: Serena Ruan <82044803+serena-ruan@users.noreply.github.com> * check null bytes Signed-off-by: Serena Ruan <serena.rxy@gmail.com> * remove recursive checking Signed-off-by: Serena Ruan <serena.rxy@gmail.com> * add multiple dots test Signed-off-by: Serena Ruan <serena.rxy@gmail.com> * Update mlflow/server/handlers.py Co-authored-by: Harutaka Kawamura <hkawamura0130@gmail.com> Signed-off-by: Serena Ruan <82044803+serena-ruan@users.noreply.github.com> --------- Signed-off-by: Serena Ruan <serena.rxy@gmail.com> Signed-off-by: Serena Ruan <82044803+serena-ruan@users.noreply.github.com> Co-authored-by: Harutaka Kawamura <hkawamura0130@gmail.com>
Related Issues/PRs
#xxxWhat changes are proposed in this pull request?
check additional situations that might contain security issues
How is this patch tested?
Does this PR change the documentation?
Release Notes
Is this a user-facing change?
(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/artifacts: Artifact stores and artifact loggingarea/build: Build and test infrastructure for MLflowarea/docs: MLflow documentation pagesarea/examples: Example codearea/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registryarea/models: MLmodel format, model serialization/deserialization, flavorsarea/recipes: Recipes, Recipe APIs, Recipe configs, Recipe Templatesarea/projects: MLproject format, project running backendsarea/scoring: MLflow Model server, model deployment tools, Spark UDFsarea/server-infra: MLflow Tracking server backendarea/tracking: Tracking Service, tracking client APIs, autologgingInterface
area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Modelsarea/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registryarea/windows: Windows supportLanguage
language/r: R APIs and clientslanguage/java: Java APIs and clientslanguage/new: Proposals for new client languagesIntegrations
integrations/azure: Azure and Azure ML integrationsintegrations/sagemaker: SageMaker integrationsintegrations/databricks: Databricks integrationsHow should the PR be classified in the release notes? Choose one:
rn/breaking-change- The PR will be mentioned in the "Breaking Changes" sectionrn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/feature- A new user-facing feature worth mentioning in the release notesrn/bug-fix- A user-facing bug fix worth mentioning in the release notesrn/documentation- A user-facing documentation change worth mentioning in the release notes