Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

max_score is incorrect when --allScores option is used #8

Closed
iljungr opened this Issue May 5, 2012 · 0 comments

Comments

Projects
None yet
2 participants
Collaborator

iljungr commented May 5, 2012

Run with these arguments:
12flies -f3 --allScores --orf=ATGStop --minCodons=1 Bug.fa --species=dmel,dsim

Result:
Bug.fa orf_score(decibans) -90.7230 93 215
Bug.fa orf_score(decibans) -9.3641 100 111
Bug.fa orf_score(decibans) -15.4172 160 237
Bug.fa orf_score(decibans) -29.8306 65 154
Bug.fa orf_score(decibans) -40.1296 20 154
Bug.fa max_score(decibans) -90.7230 93 215

max_score is obviously not the maximum score, though without the --allScores option it correctly reports the max_score to be -9.364. In other cases, it is not the maximum absolute value, not the first, and sometimes not even one of the scores listed. (Those scores should be listed, reported separately.) Similar problems with minCodons=25 and with 12 flies.

Here's Bug.fa:

dmel
GATAGACATCAATTTGAAAAATGGGCCAAGAGAGCAGGAGCAACGAAAAACAAACACGGCGAACAATGGG
CTACCCAAAAGCAGGCGTAGAACATGAGGAATGGATTTGTTTTAGGATTTCGATTTGGAAACACCCAGTA
TTTGCAACTTGTATATAGATATGACTTTCAGTCGGTCCCCGTTAAATGTGTTGTTATACGGAACAGTCCT
TTCACGTAAACAGCTATCCCAGGACTCTTGAAGCCAGACGGCGACCTATGTGTACTCAACGTTACT
dsim
GATAGACATCAATTTGAAAAATGGGCCAAAAGAGCAGGAGCAACGAAAAACAAACACGGCGAACAATGGG
CTACCGAAAAGCAGGCGTGGAACATGAGGAATGGGTTTGTTTTAGGATTTCGATTTGGAAACATCCTATT
TTTGCACCTAGTATATAGTTATGACTTTCAGTCGGTCCCCATAAAATGTGTTGTTATATAGAACTGTCCT
CTCACGTAAACAGCCATCCCAGGACTCTTGAAGCCAGACGGCGACCTATGTATACTCAACGTTAGT

@mlin mlin added a commit that referenced this issue May 5, 2012

@mlin mlin fix --allScores (issues #7 and #8) 2ab5975

@mlin mlin closed this May 5, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment