New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

making specifying k necessary and svm using dlibml #101

Merged
merged 6 commits into from Aug 25, 2017

Conversation

Projects
None yet
3 participants
@Iron-Stark
Contributor

Iron-Stark commented Aug 5, 2017

@rcurtin @zoq

This PR contains the fix for KNC we had discussed earlier.

@rcurtin

The 'k' parameter changes look good to me. If you can take a look into the SVM issues I'd appreciate it, then we can get this merged. Thanks for the hard work. :)

Show outdated Hide outdated methods/dlibml/src/SVM.cpp
Show outdated Hide outdated methods/dlibml/src/SVM.cpp

@rcurtin rcurtin referenced this pull request Aug 7, 2017

Closed

SVM using dlibml #100

@rcurtin

This comment has been minimized.

Show comment
Hide comment
@rcurtin
Member

rcurtin commented Aug 15, 2017

@mlpack-jenkins test this

@rcurtin

Looks good to me mostly; if you can handle the comments I left, I think it will be ready for merge.

Show outdated Hide outdated methods/dlibml/src/SVM.cpp
Show outdated Hide outdated methods/dlibml/src/SVM.cpp
Show outdated Hide outdated Makefile
Show outdated Hide outdated methods/dlibml/src/SVM.cpp
@rcurtin

Thanks for the changes, I think this is ready to go. Refactoring the compilation scripts to a different file can happen in some other PR, in my opinion.

@zoq

This comment has been minimized.

Show comment
Hide comment
@zoq

zoq Aug 24, 2017

Member

Can you take a look into the merge issue?

Member

zoq commented Aug 24, 2017

Can you take a look into the merge issue?

@zoq zoq merged commit 2594fe1 into mlpack:master Aug 25, 2017

1 check passed

Benchmarks Checks Build finished.
Details
@zoq

This comment has been minimized.

Show comment
Hide comment
@zoq

zoq Aug 25, 2017

Member

Once again, nice work.

Member

zoq commented Aug 25, 2017

Once again, nice work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment