GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This PR contains the fix for KNC we had discussed earlier.
Copy options before calling the benchmark script.
Making specifying k necessary
The 'k' parameter changes look good to me. If you can take a look into the SVM issues I'd appreciate it, then we can get this merged. Thanks for the hard work. :)
Specifying options for the poly kernel
@mlpack-jenkins test this
Looks good to me mostly; if you can handle the comments I left, I think it will be ready for merge.
Merge branch 'master' of https://github.com/mlpack/benchmarks into kn…
Specify options for poly kernel
Thanks for the changes, I think this is ready to go. Refactoring the compilation scripts to a different file can happen in some other PR, in my opinion.
Can you take a look into the merge issue?
Merge branch 'master' into knn_fix
Once again, nice work.