New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression Methods using R #105

Merged
merged 6 commits into from Aug 28, 2017

Conversation

Projects
None yet
3 participants
@Iron-Stark
Contributor

Iron-Stark commented Aug 18, 2017

No description provided.

@rcurtin

Thanks for the hard work. Again only simple questions about parameters. :)

tic()
trainTask <- makeRegrTask(data = trainData, target = tar)
lr.learner <- makeLearner("regr.lm")

This comment has been minimized.

@rcurtin

rcurtin Aug 18, 2017

Member

Is there any regularization parameter for regr.lm?

@rcurtin

rcurtin Aug 18, 2017

Member

Is there any regularization parameter for regr.lm?

This comment has been minimized.

@Iron-Stark

Iron-Stark Aug 18, 2017

Contributor

It provides the following options only

           Type len   Def   Constr Req Tunable Trafo

tol numeric - 1e-07 0 to Inf - TRUE -
singular.ok logical - TRUE - - FALSE -

@Iron-Stark

Iron-Stark Aug 18, 2017

Contributor

It provides the following options only

           Type len   Def   Constr Req Tunable Trafo

tol numeric - 1e-07 0 to Inf - TRUE -
singular.ok logical - TRUE - - FALSE -

This comment has been minimized.

@rcurtin

rcurtin Aug 22, 2017

Member

Ok, that's fine. We can leave it as is.

@rcurtin

rcurtin Aug 22, 2017

Member

Ok, that's fine. We can leave it as is.

Show outdated Hide outdated methods/R/svr.r
@rcurtin

This comment has been minimized.

Show comment
Hide comment
@rcurtin
Member

rcurtin commented Aug 22, 2017

@mlpack-jenkins test this

@rcurtin

This comment has been minimized.

Show comment
Hide comment
@rcurtin
Member

rcurtin commented Aug 22, 2017

@mlpack-jenkins test this

@Iron-Stark

This comment has been minimized.

Show comment
Hide comment
@Iron-Stark

Iron-Stark Aug 23, 2017

Contributor

@rcurtin @zoq
cannot open file 'install_r_packages.r': No such file or directory. There is a script with this name in the libraries folder.. then why did this error happen?

Contributor

Iron-Stark commented Aug 23, 2017

@rcurtin @zoq
cannot open file 'install_r_packages.r': No such file or directory. There is a script with this name in the libraries folder.. then why did this error happen?

@Iron-Stark

This comment has been minimized.

Show comment
Hide comment
@Iron-Stark

Iron-Stark Aug 23, 2017

Contributor

On doing make setup.. it fails but on running bin/Rscript install_r_packages from the command line it is working.

Contributor

Iron-Stark commented Aug 23, 2017

On doing make setup.. it fails but on running bin/Rscript install_r_packages from the command line it is working.

@Iron-Stark

This comment has been minimized.

Show comment
Hide comment
@Iron-Stark

Iron-Stark Aug 23, 2017

Contributor

Never mind, found the error.

Contributor

Iron-Stark commented Aug 23, 2017

Never mind, found the error.

@rcurtin

Looks good to me. The failing tests are only because the MATLAB tunnel was down after masterblaster was rebooted, so I don't think there is any issue here. Thanks for the hard work!

@zoq

This comment has been minimized.

Show comment
Hide comment
@zoq

zoq Aug 24, 2017

Member

Can you take a look at the merge issues, let us know if you need help.

Member

zoq commented Aug 24, 2017

Can you take a look at the merge issues, let us know if you need help.

@zoq

zoq approved these changes Aug 25, 2017

There are no objections or comments at my end. Nice work!

@Iron-Stark

This comment has been minimized.

Show comment
Hide comment
@Iron-Stark

Iron-Stark Aug 26, 2017

Contributor

@rcurtin @zoq
Thanks for the appreciation. Did you get a chance to take a look at the blog post draft I sent across on IRC?

Contributor

Iron-Stark commented Aug 26, 2017

@rcurtin @zoq
Thanks for the appreciation. Did you get a chance to take a look at the blog post draft I sent across on IRC?

@zoq

This comment has been minimized.

Show comment
Hide comment
@zoq

zoq Aug 27, 2017

Member

Sorry, somehow missed the link; I really enjoyed reading the report, I guess no one has thought to see 5000 lines of additional code, it's just an amazing number, really nice work. There is only one thing, if you could convert the google doc into a blog post that would be great.

P.S.

Always ask for help as “Help will always be given at mlpack to those who need it.” ( Could not resist quoting Albus Dumbledore :-p).

Couldn't resist either :)

Member

zoq commented Aug 27, 2017

Sorry, somehow missed the link; I really enjoyed reading the report, I guess no one has thought to see 5000 lines of additional code, it's just an amazing number, really nice work. There is only one thing, if you could convert the google doc into a blog post that would be great.

P.S.

Always ask for help as “Help will always be given at mlpack to those who need it.” ( Could not resist quoting Albus Dumbledore :-p).

Couldn't resist either :)

@Iron-Stark

This comment has been minimized.

Show comment
Hide comment
@Iron-Stark

Iron-Stark Aug 28, 2017

Contributor

@zoq

Thanks for the appreciation :) . I will post the whole thing on the mlpack blog.

Contributor

Iron-Stark commented Aug 28, 2017

@zoq

Thanks for the appreciation :) . I will post the whole thing on the mlpack blog.

@zoq zoq merged commit b139c0f into mlpack:master Aug 28, 2017

1 check passed

Benchmarks Checks Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment